fix(docker): track stable Rust in the builder stage#72
Merged
Conversation
The pinned rust:1.83 predates edition2024 dependencies (clap_derive 4.6 fails to parse), breaking the image publish workflow. Track rust:1-bookworm (latest stable), matching CI's dtolnay/rust-toolchain@stable. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Val Alexander <bunsthedev@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the hosted image publish pipeline by updating the Docker builder base image to track the current stable Rust toolchain, preventing the Docker build from lagging behind the workspace’s minimum Rust/edition requirements.
Changes:
- Update the Dockerfile builder stage from a pinned Rust 1.83 image to
rust:1-bookworm(stable-tracking) to avoid edition/dependency floor mismatches duringcargo build --release --locked.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first
publish.ymlrun (from #71) failed: the Dockerfile pinsrust:1.83-bookworm, which predates edition2024 —clap_derive 4.6.1fails to parse andcargo build --release --lockedexits 101.Fix:
rust:1-bookworm(tracks latest stable), matching CI'sdtolnay/rust-toolchain@stable, so the image builder can never fall behind the workspace's dependency floor again.Verified: this is the exact error from the failed run (logs); CI compiles the same workspace on stable. The publish rerun on merge is the end-to-end verification.