fix: honor zero content length#4
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the webhook WSGI request-body reader to correctly treat a parsed CONTENT_LENGTH=0 as an empty body (instead of falling back to an EOF read), and adds a regression test to cover that case. This keeps the adapter a thin, predictable forwarder while hardening a real-world edge case in WSGI environments.
Changes:
- Treat
CONTENT_LENGTH=0as a valid length and read exactly 0 bytes fromwsgi.input. - Preserve existing behavior for missing/unparsable
CONTENT_LENGTHby keeping the bounded EOF-read path. - Add a regression unit test covering the zero-length content scenario.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
coven_github_adapter.py |
Adjusts read_request_body to honor CONTENT_LENGTH=0 by using a fixed-length read. |
tests/test_webhook_adapter.py |
Adds a unit test validating the zero-content-length behavior and expected 400 invalid json response. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONTENT_LENGTH=0as an empty request body.Verification
python3 -m unittest discover -s tests -vpython3 -m py_compile coven_github_adapter.py tests/test_webhook_adapter.pygit diff --checkscripts/smoke-webhook.sh http://127.0.0.1:8765/webhook smoke-secret