Skip to content

Fix erroneous "7" instead of "^7" constraint.#136

Merged
johanib merged 2 commits into
mainfrom
feature/fix_typo
Jan 29, 2026
Merged

Fix erroneous "7" instead of "^7" constraint.#136
johanib merged 2 commits into
mainfrom
feature/fix_typo

Conversation

@johanib

@johanib johanib commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Prior to this change, the latest phpstan made the pipeline red.

This change addresses the issues.
@johanib johanib requested a review from MKodde January 22, 2026 12:55

@MKodde MKodde left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing but net!

🧺 🏀

@johanib

johanib commented Jan 29, 2026

Copy link
Copy Markdown
Contributor Author

Nothing but net!

🧺 🏀

🐈‍⬛ 🧺

@johanib johanib merged commit cd8e4c7 into main Jan 29, 2026
2 checks passed
@johanib johanib deleted the feature/fix_typo branch January 29, 2026 09:25
kayjoosten added a commit that referenced this pull request Jul 2, 2026
Prior to this change, the bundle had no way to parse or expose the
mdui:UIInfo element (containing mdui:DisplayName entries per xml:lang)
that EngineBlock and Gateway forward on proxy AuthnRequests. Consumers
could not read the service display name from session state, making it
impossible to show the correct service name during step-up flows.

This change introduces MduiChunk — modelled on the existing
GsspUserAttributesChunk — which wraps the mdui:UIInfo DOM element and
exposes getDisplayNames() returning a lang-keyed array of display names.
ExtensionsMapperTrait now maps the UIInfo local name to MduiChunk, and
Extensions gains getMduiChunk() / hasMduiChunk() accessors. The phpstan
baseline is regenerated to remove stale suppressions.

Links:
- #136
- https://www.oasis-open.org/specs (SAML Metadata UI Extensions)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants