Accept nullable service_name on SP configuration push#606
Open
kayjoosten wants to merge 2 commits into
Open
Conversation
Gateway needs a display name to show during authentication (Gateway #624 already reads a `service_name` key from the pushed SP config JSON blob). Middleware was rejecting any config push containing that key, since ServiceProviderConfigurationValidator whitelists the exact set of allowed keys per service provider entry. Add `service_name` as an optional, nullable string: omitted keys default to null before the key-set check runs, so existing config pushes that don't set it keep working unchanged. Refs #589
CI has been intermittently failing composer install: gitlab.irstea.fr no longer resolves (DNS failure), and irstea/phpcpd-shim ships no dist archive on Packagist, so composer always has to git-clone that dead host for a fresh install. Runs only "pass" when the VCS cache happens to be warm. sebastian/phpcpd (the tool it shimmed) is back on Packagist directly, but its last release pins sebastian/cli-parser ^1.0, which conflicts with PHPUnit 10's ^2.0 requirement. phpcpd-next/phpcpd is an actively maintained successor targeting PHP 8.5+, resolves cleanly, and ships the same `phpcpd` binary our ci/qa/phpcpd script already calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gateway needs a display name to show during authentication (Gateway #624 already reads a
service_namekey from the pushed SP config JSON blob). Middleware was rejecting any config push containing that key, since ServiceProviderConfigurationValidator whitelists the exact set of allowed keys per service provider entry.Add
service_nameas an optional, nullable string: omitted keys default to null before the key-set check runs, so existing config pushes that don't set it keep working unchanged.Refs #589