Skip to content

Upgrade to PHP 8.5 and apply Rector cleanup #344

Closed

Description

@kayjoosten

Goal

Upgrade PHP runtime to 8.5, update Composer dependencies, and apply Rector cleanup.

What needs to be done

  • Bump composer.json PHP constraint to ^8.5, run composer update
  • Update Dockerfile(s)/docker-compose and CI to PHP 8.5
  • Add rector/rector: ^2.4, add rector.php:
    return RectorConfig::configure()
        ->withPaths([__DIR__.'/bin', __DIR__.'/config', __DIR__.'/src', __DIR__.'/tests'])
        ->withPhpSets()
        ->withComposerBased(symfony: true, phpunit: true)
        ->withAttributesSets(symfony: true, phpunit: true)
        ->withSkip([
            \Rector\Php84\Rector\MethodCall\NewMethodCallWithoutParenthesesRector::class,
            \Rector\Php84\Rector\Class_\DeprecatedAnnotationToDeprecatedAttributeRector::class,
        ]);
  • Apply rector, fix what it can't (implicit nullable params, __sleep/__wakeup, removed functions like xml_parser_free())
  • Full test suite + static analysis green on PHP 8.5

Activity

  1. moved this from New to Backlog in PHP developmenton Jul 15, 2026
  2. added this to the 4.2.0 milestone on Aug 18, 2026
  3. moved this from Backlog to In Progress in PHP developmenton Aug 24, 2026
  4. moved this from In Progress to In Review in PHP developmenton Aug 24, 2026
  5. kayjoosten commented on Sep 8, 2026

    @kayjoosten
    ContributorAuthor

    Update: PR #349 is CI green and re-requested for review from johanib. SF7 scope split out to #351.

  6. moved this from In Review to Delivered in PHP developmenton Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dependenciesPull requests that update a dependency file

    Type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions