Repository navigation
fix: use PUPPETEER_SKIP_DOWNLOAD in deploy workflows - #70
Merged
Merged
Conversation
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD is not read by Puppeteer 21+, so npm i was downloading Chromium on every deploy and hanging past the job's timeout-minutes (confirmed on the dev pipeline run 28939125376, which never shipped). Matches the same fix already applied to ci.yml.
rongquan1
approved these changes
Jul 9, 2026
isaackps
pushed a commit
that referenced
this pull request
Jul 9, 2026
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD is not read by Puppeteer 21+, so npm i was downloading Chromium on every deploy and hanging past the job's timeout-minutes (confirmed on the dev pipeline run 28939125376, which never shipped). Matches the same fix already applied to ci.yml.
rongquan1
pushed a commit
that referenced
this pull request
Sep 10, 2026
* fix: add migrate to trustvc banner (#69) * fix: add GitHub Actions workflow for automated S3 deployment * fix: update yml * ci: add dev deployment workflow and rename prod workflow for S3/CloudFront deployments * fix add migrate to trustvc banner * fix: update baner link * fix: update tests * fix: update tests * fix: update tests * fix: update tests * fix: update tests * fix: update tests * fix: update tests --------- Co-authored-by: isaackps <isaac.kps@gmail.com> * fix: use PUPPETEER_SKIP_DOWNLOAD in deploy workflows (#70) PUPPETEER_SKIP_CHROMIUM_DOWNLOAD is not read by Puppeteer 21+, so npm i was downloading Chromium on every deploy and hanging past the job's timeout-minutes (confirmed on the dev pipeline run 28939125376, which never shipped). Matches the same fix already applied to ci.yml. * chore: install GTM tag manager, split dev/prod containers (#72) new.admin.opencerts.io and newadmin.dev.opencerts.io previously served no tag at all. This is a static SPA with no server-side template hook, so src/gtm.ts injects the GTM script/noscript tags programmatically from main.tsx, gated on VITE_GTM_CONTAINER_ID being set. Sourced from separate GTM_CONTAINER_ID / DEV_GTM_CONTAINER_ID repo secrets per environment, mapped to VITE_GTM_CONTAINER_ID in the build step (Vite requires the VITE_ prefix to expose an env var to client code). Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: isaackps <isaac.kps@gmail.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD is not read by Puppeteer 21+, so npm i was downloading Chromium on every deploy and hanging past the job's timeout-minutes (confirmed on the dev pipeline run 28939125376, which never shipped). Matches the same fix already applied to ci.yml.