Skip to content

fix(web): keep sidebar nav icons embedded#319

Merged
jialudev merged 2 commits into
mainfrom
main__fix-sidebar-nav-icons
Jul 10, 2026
Merged

fix(web): keep sidebar nav icons embedded#319
jialudev merged 2 commits into
mainfrom
main__fix-sidebar-nav-icons

Conversation

@youngbeom-shin

@youngbeom-shin youngbeom-shin commented Jul 10, 2026

Copy link
Copy Markdown
Member

Summary

  • Render workspace sidebar navigation icons with existing React SVG components instead of CSS mask URLs.
  • Remove the unused mask class for sidebar navigation icons.

@youngbeom-shin youngbeom-shin marked this pull request as ready for review July 10, 2026 07:29
@youngbeom-shin youngbeom-shin requested a review from jialudev July 10, 2026 07:29
@jialudev

Copy link
Copy Markdown
Collaborator

The new React SVG path leaves each icon wrapped in an unstyled inline span. Because the navigation row uses a 24px line height, the inline SVG participates in baseline layout and can appear vertically shifted with different fonts, browsers, zoom levels, or device pixel ratios.

Rendering the icon directly as the flex item and adding display: block to .primaryNavIcon svg removes the baseline/descender space and keeps the icon and label vertically centered consistently.

@jialudev jialudev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

LGTM

@jialudev jialudev merged commit 78a2446 into main Jul 10, 2026
1 check passed
@jialudev jialudev deleted the main__fix-sidebar-nav-icons branch July 10, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants