feat: allow symlinks in library#1204
Open
letsfindaway wants to merge 1 commit intoOpenBoard-org:devfrom
Open
Conversation
letsfindaway
force-pushed
the
feat-library-symlinks
branch
from
b8a3b49 to
f0cc1af
Compare
letsfindaway
force-pushed
the
feat-library-symlinks
branch
from
f0cc1af to
cdc3b7e
Compare
letsfindaway
force-pushed
the
feat-library-symlinks
branch
from
cdc3b7e to
1b98018
Compare
letsfindaway
force-pushed
the
feat-library-symlinks
branch
from
1b98018 to
2af43ad
Compare
Member
|
I'm still quite afraid of what the potential impact in performances could be in a distant-storage context. In local context, did you notice during your tests any change regarding execution time of the scanning ? |
- return symlinks in allElementsInDirectory - use a common file system walker for counting and scanning - skip symlinks leading to duplicate or recursive scans - remove obsolete non-threaded functions
letsfindaway
force-pushed
the
feat-library-symlinks
branch
from
2af43ad to
1cdce41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a small remark in #1167 (comment): It is currently not possible to use symlinks within the library folders, e.g. for images, video, audio or interactive content.
When using symlinks, there is a risk to create cyclic or duplicate structures . This might have been the reason to exclude symlinks when scanning the file system for such features.
This PR handles symlinks properly, still avoiding cacles and duplicates:
See also letsfindaway#199