Open
Conversation
letsfindaway
force-pushed
the
cleanup-unused-files
branch
from
fbdf9ea to
ba18ed0
Compare
letsfindaway
force-pushed
the
cleanup-unused-files
branch
from
ba18ed0 to
2047e9b
Compare
letsfindaway
force-pushed
the
cleanup-unused-files
branch
from
2047e9b to
e6877ff
Compare
- remove src/gui/UBDocumentTreeWidget.cpp/.h replaced by UBDocumentTreeView contained in UBDocumentController at 2018-08-18 - remove src/gui/UBDocumentNavigator.cpp/.h replaced by UBBoardThumbnailsView at 2017-09-24 - remove src/customWidgets not referenced by the OpenBoard.pro file since creation at 2013-06-21 - remove plugins/cffadaptor unused files - UBCFFAdaptor.pro, postScript_mac.sh, resoures/* originally used to build standalone plugin - remove src/domain/UBDragableThumbnail.cpp/.h not referenced in the project files added in 2017-09-24, but never added to any .pri file
- remove EnableSoftwareUpdates
letsfindaway
force-pushed
the
cleanup-unused-files
branch
from
e6877ff to
55a94e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just removes a set of files which is no longer referenced by the project anywhere.
When looking though the code, I was quite often stumbling over these files. Just during my work on PR #1162 I very often searched for a symbol through the code. Especially for signals and slots using the
SIGNAL(name())andSLOT(name())syntax the cross-referencing of these function names does not work, so I had to use string search. Often the results then contained lines in these obsolete files.Removing these files from the current branch makes maintenance easier and does not change the application in any way.
src/gui/UBDocumentTreeWidget.cpp/.hreplaced by
UBDocumentTreeViewcontained inUBDocumentControllerat 2018-08-18src/gui/UBDocumentNavigator.cpp/.hreplaced by
UBBoardThumbnailsViewat 2017-09-24src/customWidgetsnot referenced by the
OpenBoard.profile since creation at 2013-06-21plugins/cffadaptorunused filesUBCFFAdaptor.pro,postScript_mac.sh,resoures/*originally used to build standalone pluginsrc/domain/UBDragableThumbnail.cpp/.hnot referenced in the project files, added in 2017-09-24, but never added to any
.prifile