Check if object is already a DICT before it is passed to JSON5.loads for parsing#401
Open
LostQuant wants to merge 3 commits intoOpenBMB:mainfrom
Open
Check if object is already a DICT before it is passed to JSON5.loads for parsing#401LostQuant wants to merge 3 commits intoOpenBMB:mainfrom
LostQuant wants to merge 3 commits intoOpenBMB:mainfrom
Conversation
LostQuant
changed the title
LostQuant
force-pushed
the
BUGFIX-issue-396
branch
from
8f39e6a to
3c409ff
Compare
LostQuant
changed the title
LostQuant
force-pushed
the
BUGFIX-issue-396
branch
from
fe72ecb to
f25629b
Compare
Author
There was a problem hiding this comment.
revert
Hi, sry if I missed anything but i dont see any comments
|
I believe this is an important commit... I have no idea why this is not merged and this solves some problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What is the nature of this change? / 这个变动的性质是？
🔗 Related Issue / 相关 Issue
#396
💡 Background or solution / 需求背景和解决方案
In many places when using JSON5.loads to parse a serialized object, it doesnt check if the argument passed is a STR. The PR is to fix it by assuming the object is not serialized and only do
json5.loadsif it turns out to be a STRING.📝 Changelog / 更新日志
Default behavior is preserved, no breaking changes/risks.