fix(agent): account for repair signals delivered at boundaries - #453
Draft
zhengdaqi wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
V24R12 fixes a domain-neutral Progress Lease accounting defect isolated by the V24R11 Case 09 product gate. When an applied boundary and a new opaque repair signal occur in the same
PreModelRequest, the model request already receives that signal; Lease now records that delivery so a strictly later preparation signal can receive the existing bounded apply turn.This is stacked on #452. Keep #451, #452, and this PR unmerged until the new V24R12 product campaign passes Gate 0, paired smoke, Case 05, and full Case 09.
Changes
repairAdvancedandrepairPreparationAdvancedas delivered in the existingboundary_gracetransition instead of resetting both delivery markers.Boundaries
maxInitialStagnantObservations=8andmaxStagnantObservations=2in the product gate.QA & Evidence
fail_closedinstead ofrepair_preparation_grace; after the two-assignment fix,25/25passed.baseline -> stagnant -> boundary_grace -> repair_preparation_grace -> renewed; combined Core suite33/33passed.fail_closedtorepair_preparation_grace.validated: true, exact apply succeeds, a durable receipt is written, state advances, input tree remains unchanged, and the frozen run is not mutated.87/87passed.311/311passed.git diff --checkpassed.Reviewer-readable evidence:
.omo/evidence/20260727-v24r12-boundary-signal-accounting/QA.md.Risks & Residuals
Local tests and preserved-session replay prove the isolated state transition and surrounding regressions. They do not prove the production model will complete Case 09 after receiving the newly available apply turn. That remains the blocking product gate; V25 and the 85-case campaign are not authorized yet.