Repository navigation
test(server): verify launcher composition on loopback - #172
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server construction checks did not prove that the actual launcher could load Utility, Bus, Net and Login together, accept a connection and stop normally.
Add a permanent native process test that stages private TOML manifests, runs the real launcher and plugin libraries on an ephemeral loopback port, observes a connection, requests SIGTERM, completes the TCP half-close, and verifies exit 0 plus listener release. Wire it into the existing server checks on supported Unix platforms and document the exact boundary in both languages.
Validation:
The first raw-peer test waited for process exit before replying to the server FIN; correcting that test ordering passed on unchanged transport code. No production timeout or network implementation changed. Windows retains its existing construction checks. This verifies composition and cooperative shutdown, not account login, game routing, Godot integration or capacity.