Repository navigation
fix(core): preserve POD array state across growth failures - #170
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Growing a core POD array with a reference to one of its elements could read freed or shifted storage. Capacity arithmetic could wrap allocation bytes, while a failed allocation could leave array_map's name index inconsistent with its pointer array.
Snapshot aliased values before mutation, validate element counts before byte arithmetic, and reject null allocations with std::bad_alloc. Impossible capacities throw std::length_error. Keep existing mutation signatures and non-owning pointer semantics. Roll back a pointer append if index insertion fails; spare capacity may remain grown, while logical entries and lookups stay unchanged. Include the required null check in the default string-index allocator and synchronized English/Chinese guidance.
Validation on macOS arm64, C++20, exact CI arknet pin:
No ownership or layout redesign, real system OOM, large live allocation or deployment-capacity claim. Required hosted checks remain separate. Rebuild consumers/plugins to receive the corrected inline implementations.