Skip to content

[python] serialize booleans as lowercase in all parameter styles #24359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fa0311 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[python] serialize booleans as lowercase in all parameter styles #24359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd46478
[python] serialize booleans as lowercase in all parameter styles
fa0311 Jul 20, 2026
b6b1894
update samples
fa0311 Jul 20, 2026
b2e9e74
[python] update echo_api header test for lowercase boolean
fa0311 Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions modules/openapi-generator/src/main/resources/python/api_client.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,10 +646,15 @@ https://github.com/OpenAPITools/openapi-generator/blob/c84b949df1a9ec04ba75989cb
if collection_formats is None:
collection_formats = {}
for k, v in params.items() if isinstance(params, dict) else params:
if isinstance(v, bool):
v = str(v).lower()
if k in collection_formats:
collection_format = collection_formats[k]
if collection_format == 'multi':
new_params.extend((k, value) for value in v)
new_params.extend(
(k, str(value).lower() if isinstance(value, bool) else value)
for value in v
)
else:
if collection_format == 'ssv':
delimiter = ' '
Expand All @@ -660,7 +665,9 @@ https://github.com/OpenAPITools/openapi-generator/blob/c84b949df1a9ec04ba75989cb
else: # csv is the default
delimiter = ','
new_params.append(
(k, delimiter.join(str(value) for value in v)))
(k, delimiter.join(
str(value).lower() if isinstance(value, bool) else str(value)
for value in v)))
else:
new_params.append((k, v))
return new_params
Expand All @@ -686,7 +693,10 @@ https://github.com/OpenAPITools/openapi-generator/blob/c84b949df1a9ec04ba75989cb
if k in collection_formats:
collection_format = collection_formats[k]
if collection_format == 'multi':
new_params.extend((k, quote(str(value))) for value in v)
new_params.extend(
(k, quote(str(value).lower() if isinstance(value, bool) else str(value)))
for value in v
)
else:
if collection_format == 'ssv':
delimiter = ' '
Expand All @@ -697,7 +707,9 @@ https://github.com/OpenAPITools/openapi-generator/blob/c84b949df1a9ec04ba75989cb
else: # csv is the default
delimiter = ','
new_params.append(
(k, delimiter.join(quote(str(value)) for value in v))
(k, delimiter.join(
quote(str(value).lower() if isinstance(value, bool) else str(value))
for value in v))
)
else:
new_params.append((k, quote(str(v))))
Expand Down
20 changes: 16 additions & 4 deletions ...ent/echo_api/python-disallowAdditionalPropertiesIfNotPresent/openapi_client/api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,10 +489,15 @@ def parameters_to_tuples(self, params, collection_formats):
if collection_formats is None:
collection_formats = {}
for k, v in params.items() if isinstance(params, dict) else params:
if isinstance(v, bool):
v = str(v).lower()
if k in collection_formats:
collection_format = collection_formats[k]
if collection_format == 'multi':
new_params.extend((k, value) for value in v)
new_params.extend(
(k, str(value).lower() if isinstance(value, bool) else value)
for value in v
)
else:
if collection_format == 'ssv':
delimiter = ' '
Expand All @@ -503,7 +508,9 @@ def parameters_to_tuples(self, params, collection_formats):
else: # csv is the default
delimiter = ','
new_params.append(
(k, delimiter.join(str(value) for value in v)))
(k, delimiter.join(
str(value).lower() if isinstance(value, bool) else str(value)
for value in v)))
else:
new_params.append((k, v))
return new_params
Expand All @@ -529,7 +536,10 @@ def parameters_to_url_query(self, params, collection_formats):
if k in collection_formats:
collection_format = collection_formats[k]
if collection_format == 'multi':
new_params.extend((k, quote(str(value))) for value in v)
new_params.extend(
(k, quote(str(value).lower() if isinstance(value, bool) else str(value)))
for value in v
)
else:
if collection_format == 'ssv':
delimiter = ' '
Expand All @@ -540,7 +550,9 @@ def parameters_to_url_query(self, params, collection_formats):
else: # csv is the default
delimiter = ','
new_params.append(
(k, delimiter.join(quote(str(value)) for value in v))
(k, delimiter.join(
quote(str(value).lower() if isinstance(value, bool) else str(value))
for value in v))
)
else:
new_params.append((k, quote(str(v))))
Expand Down
20 changes: 16 additions & 4 deletions samples/client/echo_api/python/openapi_client/api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,10 +489,15 @@ def parameters_to_tuples(self, params, collection_formats):
if collection_formats is None:
collection_formats = {}
for k, v in params.items() if isinstance(params, dict) else params:
if isinstance(v, bool):
v = str(v).lower()
if k in collection_formats:
collection_format = collection_formats[k]
if collection_format == 'multi':
new_params.extend((k, value) for value in v)
new_params.extend(
(k, str(value).lower() if isinstance(value, bool) else value)
for value in v
)
else:
if collection_format == 'ssv':
delimiter = ' '
Expand All @@ -503,7 +508,9 @@ def parameters_to_tuples(self, params, collection_formats):
else: # csv is the default
delimiter = ','
new_params.append(
(k, delimiter.join(str(value) for value in v)))
(k, delimiter.join(
str(value).lower() if isinstance(value, bool) else str(value)
for value in v)))
else:
new_params.append((k, v))
return new_params
Expand All @@ -529,7 +536,10 @@ def parameters_to_url_query(self, params, collection_formats):
if k in collection_formats:
collection_format = collection_formats[k]
if collection_format == 'multi':
new_params.extend((k, quote(str(value))) for value in v)
new_params.extend(
(k, quote(str(value).lower() if isinstance(value, bool) else str(value)))
for value in v
)
else:
if collection_format == 'ssv':
delimiter = ' '
Expand All @@ -540,7 +550,9 @@ def parameters_to_url_query(self, params, collection_formats):
else: # csv is the default
delimiter = ','
new_params.append(
(k, delimiter.join(quote(str(value)) for value in v))
(k, delimiter.join(
quote(str(value).lower() if isinstance(value, bool) else str(value))
for value in v))
)
else:
new_params.append((k, quote(str(v))))
Expand Down
2 changes: 1 addition & 1 deletion samples/client/echo_api/python/tests/test_manual.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def testHeaderParameters(self):
e = EchoServerResponseParser(api_response)
expected_header = dict(
integer_header="123",
boolean_header="True",
boolean_header="true",
string_header="string_value",
enum_nonref_string_header="success",
enum_ref_string_header="failure",
Expand Down
20 changes: 16 additions & 4 deletions ...les/client/others/python-legacy-model-dictionaries/legacy_model_dict_client/api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,10 +597,15 @@ def parameters_to_tuples(self, params, collection_formats):
if collection_formats is None:
collection_formats = {}
for k, v in params.items() if isinstance(params, dict) else params:
if isinstance(v, bool):
v = str(v).lower()
if k in collection_formats:
collection_format = collection_formats[k]
if collection_format == 'multi':
new_params.extend((k, value) for value in v)
new_params.extend(
(k, str(value).lower() if isinstance(value, bool) else value)
for value in v
)
else:
if collection_format == 'ssv':
delimiter = ' '
Expand All @@ -611,7 +616,9 @@ def parameters_to_tuples(self, params, collection_formats):
else: # csv is the default
delimiter = ','
new_params.append(
(k, delimiter.join(str(value) for value in v)))
(k, delimiter.join(
str(value).lower() if isinstance(value, bool) else str(value)
for value in v)))
else:
new_params.append((k, v))
return new_params
Expand All @@ -637,7 +644,10 @@ def parameters_to_url_query(self, params, collection_formats):
if k in collection_formats:
collection_format = collection_formats[k]
if collection_format == 'multi':
new_params.extend((k, quote(str(value))) for value in v)
new_params.extend(
(k, quote(str(value).lower() if isinstance(value, bool) else str(value)))
for value in v
)
else:
if collection_format == 'ssv':
delimiter = ' '
Expand All @@ -648,7 +658,9 @@ def parameters_to_url_query(self, params, collection_formats):
else: # csv is the default
delimiter = ','
new_params.append(
(k, delimiter.join(quote(str(value)) for value in v))
(k, delimiter.join(
quote(str(value).lower() if isinstance(value, bool) else str(value))
for value in v))
)
else:
new_params.append((k, quote(str(v))))
Expand Down
20 changes: 16 additions & 4 deletions samples/openapi3/client/petstore/python-aiohttp/petstore_api/api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,10 +488,15 @@ def parameters_to_tuples(self, params, collection_formats):
if collection_formats is None:
collection_formats = {}
for k, v in params.items() if isinstance(params, dict) else params:
if isinstance(v, bool):
v = str(v).lower()
if k in collection_formats:
collection_format = collection_formats[k]
if collection_format == 'multi':
new_params.extend((k, value) for value in v)
new_params.extend(
(k, str(value).lower() if isinstance(value, bool) else value)
for value in v
)
else:
if collection_format == 'ssv':
delimiter = ' '
Expand All @@ -502,7 +507,9 @@ def parameters_to_tuples(self, params, collection_formats):
else: # csv is the default
delimiter = ','
new_params.append(
(k, delimiter.join(str(value) for value in v)))
(k, delimiter.join(
str(value).lower() if isinstance(value, bool) else str(value)
for value in v)))
else:
new_params.append((k, v))
return new_params
Expand All @@ -528,7 +535,10 @@ def parameters_to_url_query(self, params, collection_formats):
if k in collection_formats:
collection_format = collection_formats[k]
if collection_format == 'multi':
new_params.extend((k, quote(str(value))) for value in v)
new_params.extend(
(k, quote(str(value).lower() if isinstance(value, bool) else str(value)))
for value in v
)
else:
if collection_format == 'ssv':
delimiter = ' '
Expand All @@ -539,7 +549,9 @@ def parameters_to_url_query(self, params, collection_formats):
else: # csv is the default
delimiter = ','
new_params.append(
(k, delimiter.join(quote(str(value)) for value in v))
(k, delimiter.join(
quote(str(value).lower() if isinstance(value, bool) else str(value))
for value in v))
)
else:
new_params.append((k, quote(str(v))))
Expand Down
20 changes: 16 additions & 4 deletions samples/openapi3/client/petstore/python-httpx-sync/petstore_api/api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,10 +491,15 @@ def parameters_to_tuples(self, params, collection_formats):
if collection_formats is None:
collection_formats = {}
for k, v in params.items() if isinstance(params, dict) else params:
if isinstance(v, bool):
v = str(v).lower()
if k in collection_formats:
collection_format = collection_formats[k]
if collection_format == 'multi':
new_params.extend((k, value) for value in v)
new_params.extend(
(k, str(value).lower() if isinstance(value, bool) else value)
for value in v
)
else:
if collection_format == 'ssv':
delimiter = ' '
Expand All @@ -505,7 +510,9 @@ def parameters_to_tuples(self, params, collection_formats):
else: # csv is the default
delimiter = ','
new_params.append(
(k, delimiter.join(str(value) for value in v)))
(k, delimiter.join(
str(value).lower() if isinstance(value, bool) else str(value)
for value in v)))
else:
new_params.append((k, v))
return new_params
Expand All @@ -531,7 +538,10 @@ def parameters_to_url_query(self, params, collection_formats):
if k in collection_formats:
collection_format = collection_formats[k]
if collection_format == 'multi':
new_params.extend((k, quote(str(value))) for value in v)
new_params.extend(
(k, quote(str(value).lower() if isinstance(value, bool) else str(value)))
for value in v
)
else:
if collection_format == 'ssv':
delimiter = ' '
Expand All @@ -542,7 +552,9 @@ def parameters_to_url_query(self, params, collection_formats):
else: # csv is the default
delimiter = ','
new_params.append(
(k, delimiter.join(quote(str(value)) for value in v))
(k, delimiter.join(
quote(str(value).lower() if isinstance(value, bool) else str(value))
for value in v))
)
else:
new_params.append((k, quote(str(v))))
Expand Down
20 changes: 16 additions & 4 deletions samples/openapi3/client/petstore/python-httpx/petstore_api/api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,10 +491,15 @@ def parameters_to_tuples(self, params, collection_formats):
if collection_formats is None:
collection_formats = {}
for k, v in params.items() if isinstance(params, dict) else params:
if isinstance(v, bool):
v = str(v).lower()
if k in collection_formats:
collection_format = collection_formats[k]
if collection_format == 'multi':
new_params.extend((k, value) for value in v)
new_params.extend(
(k, str(value).lower() if isinstance(value, bool) else value)
for value in v
)
else:
if collection_format == 'ssv':
delimiter = ' '
Expand All @@ -505,7 +510,9 @@ def parameters_to_tuples(self, params, collection_formats):
else: # csv is the default
delimiter = ','
new_params.append(
(k, delimiter.join(str(value) for value in v)))
(k, delimiter.join(
str(value).lower() if isinstance(value, bool) else str(value)
for value in v)))
else:
new_params.append((k, v))
return new_params
Expand All @@ -531,7 +538,10 @@ def parameters_to_url_query(self, params, collection_formats):
if k in collection_formats:
collection_format = collection_formats[k]
if collection_format == 'multi':
new_params.extend((k, quote(str(value))) for value in v)
new_params.extend(
(k, quote(str(value).lower() if isinstance(value, bool) else str(value)))
for value in v
)
else:
if collection_format == 'ssv':
delimiter = ' '
Expand All @@ -542,7 +552,9 @@ def parameters_to_url_query(self, params, collection_formats):
else: # csv is the default
delimiter = ','
new_params.append(
(k, delimiter.join(quote(str(value)) for value in v))
(k, delimiter.join(
quote(str(value).lower() if isinstance(value, bool) else str(value))
for value in v))
)
else:
new_params.append((k, quote(str(v))))
Expand Down
Loading
Loading