Refactor: Extract duplicated CMS collection patterns into shared utilities

[Copilot]

CMS collection files contained ~400 lines of duplicated code across database operations, validation, and access control patterns.

Changes

New Utilities

cms/src/utilities/validation.ts

• normalizeUrl(), normalizeEmail() - Previously duplicated in 3 and 2 files respectively
• extractTags(), extractFeatureList(), serializeValue() - Common data extraction patterns

cms/src/utilities/upsert-factory.ts

• createUpsertHook() - Factory replacing 50-100 lines of boilerplate per collection
• Handles ID/non-ID inserts, JSONB casting, error handling, and Supabase ID backfill

cms/src/utilities/collection-helpers.ts

• Shared access control patterns: publicReadAuthWrite, adminOnlyAccess
• Common field definitions: supabaseIdField, activeField

Updated Collections

Refactored Solutions, Repositories, HomepageFeatures, TeamMembers, Leads, NewsletterSubscribers, and SiteSettings to use shared utilities.

Before:

const normalizeUrl = (value: unknown): string | null => { /* 10 lines */ };

const upsertIntoSupabase = async ({ doc, req }) => {
  const supabaseId = doc.supabaseId ?? null;
  // 80+ lines of query building, error handling, logging...
};

const Collection: CollectionConfig = {
  access: {
    read: () => true,
    create: ({ req }) => Boolean(req.user),
    // ...
  },
  fields: [
    { name: 'supabaseId', type: 'text', admin: { hidden: true } },
    // ...
  ],
};

After:

import { normalizeUrl } from '../utilities/validation';
import { createUpsertHook } from '../utilities/upsert-factory';
import { publicReadAuthWrite, supabaseIdField } from '../utilities/collection-helpers';

const upsertIntoSupabase = createUpsertHook({
  collectionName: 'repositories',
  tableName: 'repositories',
  extractData: (doc) => ({
    name: resolveLocalizedText(doc.name),
    github_url: normalizeUrl(doc.githubUrl),
    // ...
  }),
});

const Collection: CollectionConfig = {
  access: publicReadAuthWrite,
  fields: [supabaseIdField, /* ... */],
};

Impact

• -300 net lines (783 removed, 483 added)
• Database operation changes now propagate to all collections from single source
• Validation logic centralized and testable independently

Original prompt

Find and refactor duplicated code

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Avoid referencing missing updated_at columns in upserts

The new createUpsertHook always appends updated_at=now() to the ON CONFLICT … DO UPDATE clause. Several collections that now use this factory (e.g. Leads, NewsletterSubscribers) write to tables that only define created_at and have no updated_at column in the migrations. Running their hooks will therefore raise column "updated_at" of relation … does not exist, preventing new leads/subscribers from syncing and blocking the Supabase ID backfill. Consider making the timestamp update conditional or configurable per table.

Useful? React with 👍 / 👎.