优化深色主题视觉#711
Open
NarwhalChen wants to merge 2 commits into
Open
Conversation
Contributor
PR Reviewer Guide 🔍(Review updated until commit 28f69ed)Here are some key observations to aid the review process:
|
Contributor
|
Persistent review updated to latest commit 28f69ed |
Contributor
|
Persistent review updated to latest commit 28f69ed |
Contributor
|
Persistent review updated to latest commit 28f69ed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
改动说明
这次主要调整 OpenLess 的深色主题观感,并顺手修掉概览页指标区一个多余的外层边框。
截图
浅色主题
深色主题
验证
npm run buildnpm run check:macos-capsule-spacesnpm run check:windows-startup-lifecyclegit diff --check说明:
npm run build仍会输出已有的 IPC circular chunk warning,涉及getSettings/setSettings的分块循环;这个 warning 不是本次视觉调整引入的。PR Type
Enhancement
Description
Rework dark theme tokens for clearer layering
Replace hardcoded colors with theme variables
Remove redundant border in overview metrics
Update sidebar, settings, and capsule variables
File Walkthrough
tokens.css
Rework dark theme token variablesopenless-all/app/src/styles/tokens.css
and borders
segmented, toggle, capsule tokens
FloatingShell.tsx
Use theme variables in FloatingShellopenless-all/app/src/components/FloatingShell.tsx
sidebar pill and segmented active shadow
var(--ol-blue-soft)and add border for beta tagvar(--ol-sidebar-settings-active-bg)andvar(--ol-segmented-active-shadow)for settings buttonSettingsModal.tsx
Use theme variables in SettingsModalopenless-all/app/src/components/SettingsModal.tsx
var(--ol-settings-content-bg)var(--ol-segmented-active-shadow)for segmented pillvar(--ol-settings-close-hover-bg)for close button hovershared.tsx
Use theme variables for toggle colorsopenless-all/app/src/pages/settings/shared.tsx
var(--ol-toggle-off-bg)var(--ol-toggle-knob)Overview.tsx
Remove extra border from overview metricsopenless-all/app/src/pages/Overview.tsx
.ol-overview-herofrom metric grid,eliminating redundant border
global.css
Remove deprecated overview hero classopenless-all/app/src/styles/global.css
.ol-overview-heroclass definition since it's no longer used