fix(onboarding): require macOS Accessibility grant before first-run completes

[appergb]

User description

Problem

On macOS, first-run onboarding could complete after Microphone only and drop the user into the main UI without Accessibility granted — so the global hotkey silently does nothing and the app looks broken.

Cause

DesktopOnboarding gated completion on the hotkey capability flag requiresAccessibilityPermission:

const aOk = !requiresAccessibility || a === 'granted' || a === 'notApplicable';

That flag comes from an async IPC and is null while it loads → requiresAccessibility is briefly false → aOk is true. If Microphone gets granted inside that window, refresh() calls onComplete() before Accessibility was ever requested. The accessibility step ({requiresAccessibility && …}) hadn't rendered yet either. Meanwhile App.tsx's startup gate always requires Accessibility, so the two disagreed.

Confirmed in source: macOS HotkeyCapability has requires_accessibility_permission: true (types.rs), but the TS fallback/mock default to false.

Fix (Onboarding.tsx, desktop path only)

1. Gate on the real permission status, mirroring App.tsx — timing-independent, capability-flag-independent:

   const aOk = a === 'granted' || a === 'notApplicable';

   check_accessibility() returns granted/denied on macOS and notApplicable on Windows/Linux/Android, so this requires Accessibility exactly where it's needed.
2. Show the Accessibility step whenever it's denied (a macOS-only state) in addition to the capability flag, so the step reliably appears even before/if the capability hasn't loaded.
3. Drop the capability dependency from the grant button's disabled, so it's actionable in that same window.

Behavior

• macOS: onboarding now stays until both Accessibility and Microphone are granted. No more "in the app but hotkey dead."
• Windows / Linux / Android: Accessibility is notApplicable → aOk true, step hidden → unchanged.

Test plan

• npx tsc --noEmit — clean
• macOS fresh-run (TCC reset): onboarding blocks until Accessibility granted; grant flow opens System Settings; completes only after both
• Windows/Linux: onboarding unchanged (mic-only), CI build green

Base: beta.

---

PR Type

Bug fix

---

Description

• Fix macOS onboarding completing without Accessibility granted

• Gate completion on real permission status, not capability flag

• Show Accessibility step when denied even before capability loads

• Drop capability dependency from grant button disabled state

---

Diagram Walkthrough

flowchart LR
  A["Onboarding refresh()"] --> B["Check permissions"]
  B --> C{"Accessibility = granted or notApplicable?"}
  C -- "True" --> D{"Microphone = granted or notApplicable?"}
  D -- "True" --> E["onComplete()"]
  D -- "False" --> F["Wait for Mic grant"]
  C -- "False" --> G["Show Accessibility step"]
  G --> H["User grants Accessibility"]
  H --> B

Loading

File Walkthrough

Relevant files

Bug fix

Onboarding.tsx Fix Accessibility permission gating and step visibility    openless-all/app/src/components/Onboarding.tsx Modified refresh() to gate completion on real accessibility permission status instead of requiresAccessibility flag Changed rendering condition for Accessibility step to include accessibility === 'denied' Removed capability?.requiresAccessibilityPermission from grant button disabled condition Updated step index calculation to account for accessibility step when denied +9/-4

---

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ No major issues detected