feat(dashboard): set Dependency Latency visualization to Heatmap - #116
feat(dashboard): set Dependency Latency visualization to Heatmap#116anant-shipit wants to merge 3 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Dependency Latency panel changes from a Grafana time series to a heatmap. Its Prometheus target uses outgoing request duration histogram buckets grouped by ChangesDependency latency visualization
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized dashboard change updates the Dependency Latency panel to a heatmap and adjusts its PromQL query; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Linked Issues checkExplanation The changes implement the heatmap visualization and histogram-bucket query requested by issue Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@grafana/dashboards/watchdog_metrics_dashboard.json`:
- Line 198: Update the PromQL expression in the dashboard’s outgoing request
duration panel to replace the no-op url matcher with server_id=~"$server_id",
preserving the existing rate, sum, and le aggregation so the dashboard respects
server-level filtering.
- Line 161: In the dashboard panel configuration, change the "calculate" setting
from true to false so Grafana uses the pre-calculated Prometheus histogram
buckets and preserves their "le" boundaries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 15a9f4c4-611e-461f-a1e8-7a8091ffc913
📒 Files selected for processing (1)
grafana/dashboards/watchdog_metrics_dashboard.json
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Fixes #97
Design Decisions Summary
Grouping & Panel Choice:
This metric remains correctly grouped under "System Availability", but the default timeseries panel compressed request duration distributions into a single line, masking bimodal patterns.
Visualization Rationale:
I chose a Heatmap for this panel. Latency is fundamentally a distribution, not a single average. A heatmap visualizes the distribution of request durations over time, making it easy to instantly spot long-tail outliers (like degraded downstream servers) that a simple line chart would hide.
Go Metric Modifications:
No Go metric types were modified. However, the PromQL query was updated to use
sum(rate(http_outgoing_request_duration_seconds_bucket[5m])) by (le)to properly feed the heatmap.Summary by CodeRabbit