Remove Logger from Application struct - #1416
Conversation
After the changes in !1401, all the RestAPI server handlers will retrieve the logger from the request context. Removing the Logger field from Application enforces that api.Logger is not used directly and encourages getting the logger from the request context. Verified that there is no code that accesses Application's Logger and that all unit tests pass.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Performance Smoke Test ResultsStatus: PASSED
Smoke test config: 5 VUs x 30s. Thresholds: p(95) < 300ms, error rate < 1%. Full results uploaded as workflow artifact: k6-smoke-summary. |
1 participant
After the changes in !1401, all the RestAPI server handlers will retrieve the logger from the request context. Removing the Logger field from Application enforces that api.Logger is not used directly and encourages getting the logger from the request context.
Application's Logger was only being used by the RestAPI handlers so removing it does not affect any other components. Verified that all unit tests pass.