feat: legg til get_posts() for å hente innlegg fra gruppevegger#219
Open
Starefossen wants to merge 2 commits intoOlen:mainfrom
Open
feat: legg til get_posts() for å hente innlegg fra gruppevegger#219Starefossen wants to merge 2 commits intoOlen:mainfrom
Starefossen wants to merge 2 commits intoOlen:mainfrom
Conversation
Starefossen
added a commit
to Starefossen/spond-no-match-mcp
that referenced
this pull request
Mar 3, 2026
- Add rsvpDate (svarfrist) display in event summaries - Add meetupTimestamp display as oppmøte time - Add matchInfo display (hjemme/borte) - Add cancelledReason display - Refactor event fetching to single all-groups API call - Filter events client-side by kid/group using recipients.group.id - Remove posts code (waiting for upstream PR Olen/Spond#219) - 99 tests passing
Author
|
Ping @Olen - any chance we can get this merged? |
Owner
|
Please fix the ruff issues, other than that, it looks fine to me. |
Add a new get_posts() method to the Spond class that retrieves posts from group walls via the /core/v1/posts API endpoint. Posts are announcements/messages posted to group walls, distinct from chat messages (get_messages) and events (get_events). Supports filtering by group_id, setting max_posts limit, and toggling comment inclusion. Closes Olen#67
Starefossen
force-pushed
the
feature/get-posts
branch
from
ca34ca5 to
9d3b6d5
Compare
Author
|
Should be better now? |
There was a problem hiding this comment.
Pull request overview
Adds support in the Spond client to fetch “posts” (group wall announcements) from the /core/v1/posts endpoint, addressing the use case in #67.
Changes:
- Introduces
Spond.get_posts()with support forgroup_id,max_posts, andinclude_commentsquery params. - Adds
self.postsstorage on the client instance. - Adds a dedicated test suite covering happy path, parameter handling, and API error behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
spond/spond.py |
Adds posts state and the new get_posts() API method. |
tests/test_spond.py |
Adds 5 tests validating request parameters, response handling, and error raising for get_posts(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+174
to
+178
| url = f"{self.api_url}posts" | ||
| params: dict[str, str] = { | ||
| "type": "PLAIN", | ||
| "max": str(max_posts), | ||
| "includeComments": str(include_comments).lower(), |
Comment on lines
+253
to
+265
| mock_url = "https://api.spond.com/core/v1/posts" | ||
| mock_get.assert_called_once_with( | ||
| mock_url, | ||
| headers={ | ||
| "content-type": "application/json", | ||
| "Authorization": f"Bearer {mock_token}", | ||
| }, | ||
| params={ | ||
| "type": "PLAIN", | ||
| "max": "20", | ||
| "includeComments": "true", | ||
| }, | ||
| ) |
elliot-100
approved these changes
Mar 15, 2026
Collaborator
There was a problem hiding this comment.
Fine with me, but would be nice to include that suggested minor consistency issue.
@Olen forgot to add, I have used the code to successfully retrieve live posts.
Thanks @Starefossen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beskrivelse
Legger til en ny
get_posts()-metode iSpond-klassen for å hente innlegg (posts) fra gruppevegger via API-endepunktet/core/v1/posts.Innlegg er kunngjøringer/meldinger som publiseres på gruppevegger, og er forskjellig fra chatmeldinger (
get_messages) og hendelser (get_events).Parametere
group_idstr | NoneNonemax_postsint20include_commentsboolTrueEksempel
Tester
5 nye tester er lagt til i
tests/test_spond.py:group_idmax_postsinclude_comments=FalseAlle eksisterende og nye tester bestått.
Closes #67