Skip to content

Fix test to match new Python 3.10+ requirement - #171

Open
karlwaldman wants to merge 1 commit into
mainfrom
cursor/fix-python-version-test-8e81
Open

karlwaldman wants to merge 1 commit into
mainfrom
cursor/fix-python-version-test-8e81

Conversation

@karlwaldman

Copy link
Copy Markdown
Member

Fixes the failing test_packaging_configuration_remains_compatible_with_supported_python test on main.

Issue

PR #170 updated requires-python from >=3.8 to >=3.10, but the corresponding test still expected >=3.8, causing test failures on main.

Changes

  • Updated test_packaging_configuration_remains_compatible_with_supported_python to expect requires-python = ">=3.10"
  • Updated the setuptools comment to match the simplified version in pyproject.toml (no longer mentions Python 3.8 compatibility)

Testing

This change updates the test assertion to match the actual configuration, so all tests should pass once CI runs.

Open in Web Open in Cursor 

Update test_packaging_configuration_remains_compatible_with_supported_python
to expect requires-python >= 3.10 instead of >= 3.8, matching the change
in PR #170. Also update the setuptools comment to match the simplified
version in pyproject.toml.

Co-authored-by: karlwaldman <karl.waldman@gmail.com>
@coderabbitai

coderabbitai Bot commented Nov 15, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7f95dd2d-e73e-4507-b71e-c034850b6a6c
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants