Skip to content

fix(release): poll npm readback for up to 10 minutes (#127) - #128

Merged
karlwaldman merged 1 commit into
mainfrom
fix/127-publish-readback
Oct 3, 2026
Merged

karlwaldman merged 1 commit into
mainfrom
fix/127-publish-readback

Conversation

@karlwaldman

Copy link
Copy Markdown
Member

Closes #127.

Problem

In run 37155988257, the v2.1.0 publish logged + oilpriceapi@2.1.0 at 21:42:29Z. The readback loop (12 tries, 5s apart, about 67s in all) then gave up at 21:43:36Z, and Attach verified release assets was skipped. npm served 2.1.0 about 5 minutes later, and re-running the failed jobs passed.

Change

  • The readback loop is now limited by a 10-minute deadline (SECONDS + 600) instead of 12 iterations, and sleeps 10s between tries. It uses a deadline because each try can spend up to 2 × 30s inside timeout.
  • Publish job timeout-minutes goes from 15 to 25 (10m publish cap + 10m readback).
  • The integrity and latest checks are unchanged. A version that never appears still fails.

Same fix in mcp-server: OilpriceAPI/mcp-server#149.

Verification

  • npm test: 917 pass, 1 skipped.
  • YAML parses. actionlint raises only the 2 SC2094 infos already present on main (verify job, line 86).

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 3, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6c8178de-f906-47c8-9a83-809a0fb439d6
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@karlwaldman
karlwaldman merged commit 682d5d6 into main Oct 3, 2026
8 checks passed
@karlwaldman
karlwaldman deleted the fix/127-publish-readback branch October 3, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P2][bug] publish.yml fails after a successful npm publish: readback window shorter than npm propagation

1 participant