Argo/Git: Update Vendor Identification Logic to poll http endpoint in the event of non-deterministic URL (gitlab only)#1839
Open
Argo/Git: Update Vendor Identification Logic to poll http endpoint in the event of non-deterministic URL (gitlab only)#1839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calamari is required to create PullRequests (or equivalent) in the customer's git repository.
However, this is vendor-specific behaviour (rather than generically part of git).
As such, Calamari must determine the git repository's vendor prior to attempting to create a PR.
Currently this identification is performed by parsing the repo's URL to determine the vendor (eg if the URL contains gitlab, or github etc.).
However, this process does not work if the repository is a "enterprise" server, and could therefore have any URL.
This change is a (near) duplicate of the work performed in OctopusDeploy server repository OctopusDeploy#41414 which introduces the ability to perform a "deeper introspect" of the git repository by polling known endpoints on the server.
At this stage, only GitLab is supported for this deep-inspection.