Open
Conversation
scme0
changed the title
scme0
force-pushed
the
scme/MD-1529/no-op-argocd-updates
branch
from
e2634ec to
e5ef4bd
Compare
scme0
commented
Mar 19, 2026
| // Only values.yaml should be in PatchedFiles — values-extra.yaml had no image match and must not produce a patch entry | ||
| using var scope = new AssertionScope(); | ||
| capturedResults.Should().NotBeNull(); | ||
| var sourceDetails = capturedResults.Single().UpdatedSourceDetails.First(); |
Collaborator
Author
There was a problem hiding this comment.
Updated didn't fully make sense here because not all sources are updated.
# Conflicts: # source/Calamari/ArgoCD/Conventions/UpdateArgoCDAppImagesInstallConvention.cs # Conflicts: # source/Calamari/ArgoCD/Conventions/UpdateArgoCDApplicationManifestsInstallConvention.cs
scme0
force-pushed
the
scme/MD-1529/no-op-argocd-updates
branch
from
80a757c to
48e8287
Compare
Resolve conflicts by keeping our Tracked/TrackedSourceDetail renames and incorporating main's ConvertPathsToPosix path-replacement logic. Keep our JsonPatch null-filter in AbstractHelmUpdater (path replacement is now handled in the reporter). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
scme0
force-pushed
the
scme/MD-1529/no-op-argocd-updates
branch
from
4b2c906 to
2eb2511
Compare
flin-8
reviewed
Mar 20, 2026
| log.Verbose($"Updated image reference: {change}"); | ||
| } | ||
| } | ||
| else if (imageReplacementResult.AlreadyUpToDateImages.Count > 0) |
Contributor
There was a problem hiding this comment.
Can we have a mix of UpdatedImageReferences and AlreadyUpToDateImages ? Then we would need to generate patches for both right?
Follow on question - what happens if the same image is already updated in 1 place but needs updating in another place?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MD-1529
Updating ArgoCD Steps to track all sources even if no updates are made.
There are 3 cases: