Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/sovereign_cortex/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@
from pathlib import Path
from typing import Any

from fastapi import FastAPI
from fastapi import FastAPI, HTTPException
from pydantic import BaseModel, Field

from .activity import ActivityRecordStore
from .approvals import ApprovalRequest, ApprovalStatus, ApprovalStore
from .events import CommandPayload, EventEnvelope, EventType, TaskResult
from .orchestrator import LocalOrchestrator
from .project_reports import handle_project_report
Expand Down Expand Up @@ -56,6 +57,17 @@ def run_command(request: CommandRequest) -> CommandResponse:
events=[event.model_dump(mode="json") for event in result.events],
)

@app.get("/approvals", response_model=list[ApprovalRequest])
def list_approvals(status: ApprovalStatus = "pending") -> list[ApprovalRequest]:
return ApprovalStore(root).list(status)

@app.get("/approvals/{approval_id}", response_model=ApprovalRequest)
def get_approval(approval_id: str) -> ApprovalRequest:
try:
return ApprovalStore(root).get(approval_id)
except FileNotFoundError as exc:
raise HTTPException(status_code=404, detail=str(exc)) from exc

return app


Expand Down
66 changes: 65 additions & 1 deletion tests/test_api.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
from datetime import date

from fastapi import HTTPException
import pytest

from sovereign_cortex.api import CommandRequest, build_report_result, create_app
from sovereign_cortex.events import EventType, TaskResult
from sovereign_cortex.approvals import ApprovalStore
from sovereign_cortex.events import EventType, PatchOperation, ProposedPatch, TaskResult
from sovereign_cortex.policy import PolicyDecision


def _endpoint(app, path: str):
Expand All @@ -24,12 +29,36 @@ def _write_demo_workspace(tmp_path):
)


def _write_pending_approval(tmp_path):
return ApprovalStore(tmp_path).create(
workspace="demo-project",
command_text="Update launch task",
correlation_id="test-correlation-id",
patch=ProposedPatch(
operation=PatchOperation.UPDATE_FILE,
relative_path="tasks/launch.md",
before="before",
after="after",
summary="Update launch task",
risk="medium",
requires_human_approval=True,
),
policy_decision=PolicyDecision(
allowed=True,
approval_required=True,
reason="Medium-risk patch requires approval.",
),
)


def test_app_exposes_expected_routes():
app = create_app()
paths = {route.path for route in app.routes}

assert "/health" in paths
assert "/commands" in paths
assert "/approvals" in paths
assert "/approvals/{approval_id}" in paths


def test_health_endpoint_returns_ok():
Expand Down Expand Up @@ -84,6 +113,41 @@ def handle_command(self, text: str, *, auto_approve: bool, today):
assert response.message == "stubbed"


def test_approval_list_endpoint_returns_pending_requests(tmp_path):
approval = _write_pending_approval(tmp_path)
app = create_app(tmp_path)
list_approvals = _endpoint(app, "/approvals")

response = list_approvals()

assert len(response) == 1
assert response[0].approval_id == approval.approval_id
assert response[0].status == "pending"
assert response[0].correlation_id == "test-correlation-id"


def test_approval_show_endpoint_returns_request(tmp_path):
approval = _write_pending_approval(tmp_path)
app = create_app(tmp_path)
get_approval = _endpoint(app, "/approvals/{approval_id}")

response = get_approval(approval.approval_id)

assert response.approval_id == approval.approval_id
assert response.command_text == "Update launch task"
assert response.patch.relative_path == "tasks/launch.md"


def test_approval_show_endpoint_returns_404_for_missing_request(tmp_path):
app = create_app(tmp_path)
get_approval = _endpoint(app, "/approvals/{approval_id}")

with pytest.raises(HTTPException) as error:
get_approval("missing")

assert error.value.status_code == 404


def test_project_report_result_builds_api_events(tmp_path):
_write_demo_workspace(tmp_path)

Expand Down
Loading