Repository navigation
v3.10.0: Candidate Promotion Execution - #82
Merged
Merged
Conversation
First mutation wave: promotes eligible candidates to accepted findings. Requires v3.9.0 gate pass. Preserves candidate lineage. Append-only audit. New module: src/pharabius/core/connectors/candidate_promotion.py - promote_candidate(): explicit promotion with gate validation - Lineage metadata in risk_breakdown (_promotion_lineage) - Duplicate promotion guard (one promotion per candidate) - Existing register preserved (appends, doesn't overwrite) - Lifecycle history appended (CandidateAccepted → Detected) - Summary recalculation after promotion Promotion flow: 1. Check v3.9.0 gate (9 checks) — must all pass 2. Verify not already promoted 3. Convert CandidateFinding → DebtFinding with lineage 4. Append to existing debt-register.json 5. Recalculate register summary 6. Append lifecycle entry Non-mutation guarantees: - candidate-findings.json NOT deleted or rewritten - Review decisions NOT rewritten - No auto-generated work packages, tickets, or remediation - No auto-promotion (explicit only) 25 new tests. 3,400 total (was 3,375). Signed-off-by: Alajmah <55954113+Alajmah@users.noreply.github.com>
Alajmah
added a commit
that referenced
this pull request
Jun 13, 2026
First mutation wave: promotes eligible candidates to accepted findings. Requires v3.9.0 gate pass. Preserves candidate lineage. Append-only audit. New module: src/pharabius/core/connectors/candidate_promotion.py - promote_candidate(): explicit promotion with gate validation - Lineage metadata in risk_breakdown (_promotion_lineage) - Duplicate promotion guard (one promotion per candidate) - Existing register preserved (appends, doesn't overwrite) - Lifecycle history appended (CandidateAccepted → Detected) - Summary recalculation after promotion Promotion flow: 1. Check v3.9.0 gate (9 checks) — must all pass 2. Verify not already promoted 3. Convert CandidateFinding → DebtFinding with lineage 4. Append to existing debt-register.json 5. Recalculate register summary 6. Append lifecycle entry Non-mutation guarantees: - candidate-findings.json NOT deleted or rewritten - Review decisions NOT rewritten - No auto-generated work packages, tickets, or remediation - No auto-promotion (explicit only) 25 new tests. 3,400 total (was 3,375). Signed-off-by: Alajmah <55954113+Alajmah@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First mutation wave: promotes eligible candidates to accepted DebtFindings. Requires v3.9.0 gate pass. Preserves candidate lineage. Append-only audit.
What's new
core/connectors/candidate_promotion.pypromote_candidate()Promotion flow
Lineage metadata
Every promoted finding carries
_promotion_lineageinrisk_breakdown:Non-mutation guarantees
Tests: 3,400 passed, 7 skipped (+25 new)
Boundaries preserved