Repository navigation
v3.9.0: Candidate Promotion Gate - #81
Merged
Merged
Conversation
Add eligibility rules for promoting candidate findings to accepted findings. Gate-only: checks eligibility without performing promotion. New module: src/pharabius/core/connectors/candidate_gate.py - check_promotion_eligibility(): single candidate gate check - check_all_promotion_eligibility(): batch gate check - format_eligibility_report(): single report - format_batch_eligibility_report(): batch report 9 gate checks: 1. candidate_exists — found in candidate-findings.json 2. has_accepted_decision — review decision is 'accepted' 3. has_reviewer — reviewer field non-empty 4. has_rationale — rationale field non-empty 5. has_evidence_ids — at least one evidence ID 6. has_provenance — provenance metadata present 7. has_title — title non-empty 8. has_category — category non-empty 9. has_description — description non-empty Status reader: gate-ready count for accepted candidates 28 new tests. 3,375 total (was 3,347). Boundaries preserved: - Gate is read-only — no mutation of any artifact - No writing to debt-register.json - No creating accepted DebtFinding - No work package generation - No ticket creation Signed-off-by: Alajmah <55954113+Alajmah@users.noreply.github.com>
Alajmah
added a commit
that referenced
this pull request
Jun 13, 2026
Add eligibility rules for promoting candidate findings to accepted findings. Gate-only: checks eligibility without performing promotion. New module: src/pharabius/core/connectors/candidate_gate.py - check_promotion_eligibility(): single candidate gate check - check_all_promotion_eligibility(): batch gate check - format_eligibility_report(): single report - format_batch_eligibility_report(): batch report 9 gate checks: 1. candidate_exists — found in candidate-findings.json 2. has_accepted_decision — review decision is 'accepted' 3. has_reviewer — reviewer field non-empty 4. has_rationale — rationale field non-empty 5. has_evidence_ids — at least one evidence ID 6. has_provenance — provenance metadata present 7. has_title — title non-empty 8. has_category — category non-empty 9. has_description — description non-empty Status reader: gate-ready count for accepted candidates 28 new tests. 3,375 total (was 3,347). Boundaries preserved: - Gate is read-only — no mutation of any artifact - No writing to debt-register.json - No creating accepted DebtFinding - No work package generation - No ticket creation Signed-off-by: Alajmah <55954113+Alajmah@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defines eligibility rules for promoting candidate findings to accepted findings. Gate-only: checks eligibility without performing promotion.
What's new
core/connectors/candidate_gate.py9 Gate Checks
Key design
Gate is strictly read-only. No artifact mutation.
Tests: 3,375 passed, 7 skipped (+28 new)
Boundaries preserved