Repository navigation
v3.6.0: Evidence-to-Finding Candidate Promotion - #78
Merged
Merged
Conversation
Add controlled bridge from external connector evidence to candidate findings. Candidates are review artifacts, NOT accepted debt findings. New module: src/pharabius/core/connectors/candidate.py - propose_candidates(): pure function, reads evidence, returns artifact - get_candidate_provenance(): accessor helper for provenance - write_candidate_artifact(): serializes to separate artifact - load_candidate_artifact(): loads with missing-file = empty New schema: src/pharabius/schemas/candidate.py - CandidateFinding: pre-review finding with provenance - CandidateProvenance: connector metadata (not in risk_breakdown) - CandidateFindingsArtifact: separate from DebtRegister - CandidateFindingsSummary: total_candidates, by_connector, by_category Lifecycle: FindingStatus.CANDIDATE (8th state) - Distinct from DETECTED — Candidate is pre-review - Transitions: CANDIDATE → ACKNOWLEDGED (promote), WONT_FIX (reject), DEFERRED - Cannot skip to In Progress, Verified, etc. Separate artifact: .ai-debt/candidate-findings.json - NOT mixed into debt-register.json - total_findings excludes candidates - candidate_count reported separately - Missing artifact is valid (not an error) Reporter: Candidate Findings section with 'review required' label Status reader: Shows candidate count when present 55 new tests. 3,268 total (was 3,213). Amended acceptance criteria (15-23): 15. CANDIDATE is distinct from DETECTED in lifecycle normalization 16. total_findings excludes candidates 17. candidate_count is reported separately 18. Candidate provenance has helper accessors 19. Candidate proposal is explicit and does not change analyze behavior 20. Existing exports exclude candidates 21. Governance metrics exclude candidates 22. Quality gates exclude candidates 23. Candidate sections say 'review required' Boundaries preserved: - No auto-promotion (Candidate → Acknowledged requires review) - No auto-approval - No scanner execution - No historical artifact mutation - No new CLI commands Signed-off-by: Alajmah <55954113+Alajmah@users.noreply.github.com>
Alajmah
added a commit
that referenced
this pull request
Jun 13, 2026
Add controlled bridge from external connector evidence to candidate findings. Candidates are review artifacts, NOT accepted debt findings. New module: src/pharabius/core/connectors/candidate.py - propose_candidates(): pure function, reads evidence, returns artifact - get_candidate_provenance(): accessor helper for provenance - write_candidate_artifact(): serializes to separate artifact - load_candidate_artifact(): loads with missing-file = empty New schema: src/pharabius/schemas/candidate.py - CandidateFinding: pre-review finding with provenance - CandidateProvenance: connector metadata (not in risk_breakdown) - CandidateFindingsArtifact: separate from DebtRegister - CandidateFindingsSummary: total_candidates, by_connector, by_category Lifecycle: FindingStatus.CANDIDATE (8th state) - Distinct from DETECTED — Candidate is pre-review - Transitions: CANDIDATE → ACKNOWLEDGED (promote), WONT_FIX (reject), DEFERRED - Cannot skip to In Progress, Verified, etc. Separate artifact: .ai-debt/candidate-findings.json - NOT mixed into debt-register.json - total_findings excludes candidates - candidate_count reported separately - Missing artifact is valid (not an error) Reporter: Candidate Findings section with 'review required' label Status reader: Shows candidate count when present 55 new tests. 3,268 total (was 3,213). Amended acceptance criteria (15-23): 15. CANDIDATE is distinct from DETECTED in lifecycle normalization 16. total_findings excludes candidates 17. candidate_count is reported separately 18. Candidate provenance has helper accessors 19. Candidate proposal is explicit and does not change analyze behavior 20. Existing exports exclude candidates 21. Governance metrics exclude candidates 22. Quality gates exclude candidates 23. Candidate sections say 'review required' Boundaries preserved: - No auto-promotion (Candidate → Acknowledged requires review) - No auto-approval - No scanner execution - No historical artifact mutation - No new CLI commands Signed-off-by: Alajmah <55954113+Alajmah@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds controlled bridge from external connector evidence to candidate findings. Candidates are review artifacts, NOT accepted debt findings.
What's new
core/connectors/candidate.pypropose_candidates()pure functionschemas/candidate.pyCandidateFinding,CandidateProvenancecore/lifecycle.pyFindingStatus.CANDIDATE(8th state)reporter.pystatus_reader.pyKey design: Separate artifact
total_findingsexcludes candidates.candidate_countis reported separately.Candidate lifecycle
Candidate ≠ Detected. Candidate is pre-review.
Amended acceptance criteria (15–23)
get_candidate_provenance())analyzebehaviorTests: 3,268 passed, 7 skipped (+55 new)
Boundaries preserved