Repository navigation
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f5220d9941
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 99fd1bbf08
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 049220bee6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Line 1 in 8f275de
This commit changes tools/validate.py from mode 100755 to 100644 despite retaining its executable shebang. Any existing invocation using ./tools/validate.py now fails with Permission denied; the workflow avoids this only because it explicitly runs python tools/validate.py. Restore the executable bit to preserve the CLI's previous behavior.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Addressed the latest Codex finding in |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 886f909da1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def render_markdown(year: int, events: list[dict]) -> str: | ||
| def build_payload(year: int, events: list[dict[str, Any]]) -> dict[str, Any]: | ||
| return { | ||
| "year": year, |
There was a problem hiding this comment.
Reject years outside the year-view schema
When the CLI is invoked with a pre-2017 year, such as python tools/build_year.py 2016 --format json, this function emits a payload whose year violates the minimum: 2017 constraint in year-view.schema.json. Because the argument parser accepts any integer, the generator can still produce output that fails the contract it was changed to follow; validate the requested year or align the schema's accepted range.
Useful? React with 👍 / 👎.
Summary
This stacked PR addresses the actionable Codex findings from PRs #1–#4 before further historical ingestion.
Schema hardening
typeto its canonical ID namespace.docs/ontology.mdand document the namespace map.Canonical file contract
Shared record loading
tools/records.pyas the shared loader for validation and generators..yaml,.yml, and.jsonconsistently.Year-view contract
year-view.schema.jsonusing{year, generated_from, events}.Mixtral chronology correction
weights_releasedevent.Regression coverage
Adds tests for canonical endpoint IDs, entity namespace binding, YAML date normalization, supported record extensions, one-record-per-file enforcement, and generated year-view schema conformance.
Review disposition
The GPT-4/PaLM 2 Transformer-locator Codex comment is not changed here because both cited primary-report abstracts explicitly describe the models as Transformer-based; that thread will be replied to with the supporting evidence.
Stack
Base:
atlas-2023-v0.1(PR #4)Head:
atlas-review-hardening-v0.1