Skip to content

Harden ModelMap contracts from Codex review - #5

Open
Alajmah wants to merge 5 commits into
atlas-2023-v0.1from
atlas-review-hardening-v0.1
Open

Alajmah wants to merge 5 commits into
atlas-2023-v0.1from
atlas-review-hardening-v0.1

Conversation

@Alajmah

@Alajmah Alajmah commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Summary

This stacked PR addresses the actionable Codex findings from PRs #1–#4 before further historical ingestion.

Schema hardening

  • Require canonical namespace/slug IDs for claim, relationship, and event endpoints.
  • Bind every generic entity type to its canonical ID namespace.
  • Correct the claim example in docs/ontology.md and document the namespace map.

Canonical file contract

  • Standardize on exactly one canonical record per YAML/JSON file.
  • Remove the earlier documentation allowing grouped claim arrays.

Shared record loading

  • Add tools/records.py as the shared loader for validation and generators.
  • Normalize YAML-native dates/timestamps to ISO strings before JSON Schema validation.
  • Make timeline/year generation discover .yaml, .yml, and .json consistently.

Year-view contract

  • Align generated JSON year views with year-view.schema.json using {year, generated_from, events}.

Mixtral chronology correction

  • Record the original Mixtral 8x7B weights release on 2023-12-08 using Mistral AI's magnet-link post.
  • Record the formal Mistral announcement separately on 2023-12-11.
  • Remove the incorrect 2023-12-11 weights_released event.

Regression coverage

Adds tests for canonical endpoint IDs, entity namespace binding, YAML date normalization, supported record extensions, one-record-per-file enforcement, and generated year-view schema conformance.

Review disposition

The GPT-4/PaLM 2 Transformer-locator Codex comment is not changed here because both cited primary-report abstracts explicitly describe the models as Transformer-based; that thread will be replied to with the supporting evidence.

Stack

Base: atlas-2023-v0.1 (PR #4)
Head: atlas-review-hardening-v0.1

@gitwire-hq gitwire-hq Bot added the size/L label Sep 29, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f5220d9941

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread schemas/claim.schema.json Resolved

Alajmah commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 99fd1bbf08

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread schemas/year-view.schema.json Resolved

Alajmah commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 049220bee6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tools/validate.py Resolved

Alajmah commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

#!/usr/bin/env python3

P2 Badge Restore the validator's executable bit

This commit changes tools/validate.py from mode 100755 to 100644 despite retaining its executable shebang. Any existing invocation using ./tools/validate.py now fails with Permission denied; the workflow avoids this only because it explicitly runs python tools/validate.py. Restore the executable bit to preserve the CLI's previous behavior.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Alajmah commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

Addressed the latest Codex finding in 886f909: tools/validate.py is restored to mode 100755 while retaining the current validated content. The stacked 2024 branch also preserves that executable mode so it does not regress the fix.

Alajmah commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 886f909da1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tools/build_year.py
def render_markdown(year: int, events: list[dict]) -> str:
def build_payload(year: int, events: list[dict[str, Any]]) -> dict[str, Any]:
return {
"year": year,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reject years outside the year-view schema

When the CLI is invoked with a pre-2017 year, such as python tools/build_year.py 2016 --format json, this function emits a payload whose year violates the minimum: 2017 constraint in year-view.schema.json. Because the argument parser accepts any integer, the generator can still produce output that fails the contract it was changed to follow; validate the requested year or align the schema's accepted range.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant