Repository navigation
Conversation
CodeQL js/identity-replacement #4 remediation (custom-rules/page.tsx:63): .replace("/api/config/", "/api/config/") replaced a value with itself — dead code flagged by the identity-replacement query as an unfinished edit. The generated URL was and remains /api/config/{owner}/{repo}/custom-rules, resolving against the live backend route configRouter.get('/:owner/:repo/custom-rules') (config.js:238). Regression (api-urls.test.ts): pins repoConfig(owner, repo) + '/custom-rules' === '/api/config/o/r/custom-rules' so the URL cannot drift silently when the no-op is removed. Full dashboard suite green. Signed-off-by: Alajmah <55954113+Alajmah@users.noreply.github.com>
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
🤖 AI Code Review — ✅ Approved
Confidence: high · Findings: 0
AI judgment: APPROVE · Evidence: COMPLETE · Authority: advisory
Evidence complete · 2/2 changed files accounted for
GitWire AI Review Gate (bundle-driven v2) · Structured schema · Scope-validated · AI recommendation — maintainers and repository policy retain authority
Summary
Unit 4 (final) of the authorized #425 remediation sequence. Removal of the identity-replacement no-op flagged by CodeQL
js/identity-replacement#4 atpackages/web-dashboard/src/app/custom-rules/page.tsx:63. Merge authority reserved; returned at exact head for clearance.The change
.replace("/api/config/", "/api/config/")replaced a value with itself — dead code the query flags as an unfinished edit. The generated URL was and remains/api/config/{owner}/{repo}/custom-rules, resolving against the live backend routeconfigRouter.get("/:owner/:repo/custom-rules")(config.js:238) — verified in the tranche report (PR #464 comment 7053127297). The no-op is deleted; nothing else changes.Regression
Per the directive:
tests/api-urls.test.tsnow pinsAPI.repoConfig(owner, repo) + "/custom-rules"===/api/config/o/r/custom-rules— the exact construction the page performs post-fix. Full dashboard suite 67/67.v2 note: replaces #468 — the original branch was accidentally stacked on three other unit commits; its GitWire review (row 1445, APPROVE) therefore covered all seven files of the union rather than this unit alone. This branch is a single commit on master carrying only this unit; content identical (cherry-picked).