Skip to content

docs(linux): define Wayland input strategy (Batch 13) - #23

Merged
Alajmah merged 1 commit into
mainfrom
batch-13/wayland-input-strategy
Jun 29, 2026
Merged

Alajmah merged 1 commit into
mainfrom
batch-13/wayland-input-strategy

Conversation

@Alajmah

@Alajmah Alajmah commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Batch 13 — Wayland input strategy

Issue: #21

Research/design spike. Wayland remains UNSUPPORTED for input injection.

Deliverables

docs/wayland-input-strategy.md — Full backend decision record:

  • Backend hierarchy: X11+xdotool > portal+libei/EIS > legacy Notify* > ydotool/uinput > compositor-specific
  • Decision: portal/libei preferred (consent-aware, standardized)
  • Implementation phases: detection (now) > portal prototype (opt-in) > production
  • Full XDG RemoteDesktop portal API reference (CreateSession, ConnectToEIS, Notify* methods)

deskaoy doctor — Extended for Wayland portal detection:

  • _detect_wayland_portal(): side-effect-free check for XDG portal service files
  • Reports portal backend (GNOME/KDE/wlroots) if detected
  • Reports libei availability
  • All checks are WARN/SKIP, never FAIL

RELEASE_READINESS.md — Updated Wayland section with strategy reference.

What was NOT done

  • No runtime input injection implemented
  • No fake success paths added
  • No D-Bus connections or permission prompts

Verification

  • pytest tests/test_cli -q: 159 passed
  • pytest tests/test_release_coherence.py -q: 22 passed
  • pytest tests/test_adapters -q: 243 passed, 2 skipped
  • pytest tests/integration/test_desktop_integration.py -q: 10 passed
  • ruff check src/deskaoy/diagnostics tests/test_cli/test_wayland_diagnostics.py: clean

@gitwire-hq gitwire-hq Bot added the size/L label Jun 28, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: da989192bb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/deskaoy/diagnostics/doctor.py Outdated
Comment on lines +344 to +347
for svc in d.glob("org.freedesktop.portal.*.service"):
name = svc.stem
if "RemoteDesktop" in name or "Remote" in name:
portal_found = True

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Recognize the actual portal service name

On normal xdg-desktop-portal installs the activatable service file is org.freedesktop.portal.Desktop.service, while backend files are named like org.freedesktop.impl.portal.desktop.*.service; they are not RemoteDesktop-named services. Because this check only marks files containing RemoteDesktop/Remote as present, deskaoy doctor will report not detected for Wayland users even when the portal is installed, giving incorrect diagnostics and remediation.

Useful? React with 👍 / 👎.

Batch 13 — Wayland input injection strategy (Issue #21).

Research/design spike. Wayland remains UNSUPPORTED for input injection.

docs/wayland-input-strategy.md:

- Backend hierarchy: X11+xdotool > portal+libei/EIS > legacy Notify* > ydotool/uinput > compositor-specific

- Decision record: portal/libei preferred (consent-aware, standardized)

- Implementation phases: detection (now) > portal prototype (behind opt-in) > production

- Full API reference: CreateSession, SelectDevices, Start, ConnectToEIS, Notify* methods

deskaoy doctor extensions:

- _detect_wayland_portal(): side-effect-free check for XDG RemoteDesktop portal service files

- Reports portal backend (GNOME/KDE/wlroots) if detected

- Reports libei availability (SKIP if not installed)

- All portal checks are WARN/SKIP, never FAIL

RELEASE_READINESS.md: updated Wayland section with strategy reference and portal detection note.

Tests: 6 tests covering portal not-detected (WARN), portal detected (WARN), libei SKIP/WARN, no-hard-failures invariant, Wayland input still UNSUPPORTED.
Signed-off-by: Alajmah <55954113+Alajmah@users.noreply.github.com>
@Alajmah
Alajmah force-pushed the batch-13/wayland-input-strategy branch from da98919 to 3d6ec97 Compare June 29, 2026 00:56
@Alajmah
Alajmah merged commit e588517 into main Jun 29, 2026
8 checks passed
@Alajmah
Alajmah deleted the batch-13/wayland-input-strategy branch June 29, 2026 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant