Repository navigation
docs(linux): define Wayland input strategy (Batch 13) - #23
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da989192bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for svc in d.glob("org.freedesktop.portal.*.service"): | ||
| name = svc.stem | ||
| if "RemoteDesktop" in name or "Remote" in name: | ||
| portal_found = True |
There was a problem hiding this comment.
Recognize the actual portal service name
On normal xdg-desktop-portal installs the activatable service file is org.freedesktop.portal.Desktop.service, while backend files are named like org.freedesktop.impl.portal.desktop.*.service; they are not RemoteDesktop-named services. Because this check only marks files containing RemoteDesktop/Remote as present, deskaoy doctor will report not detected for Wayland users even when the portal is installed, giving incorrect diagnostics and remediation.
Useful? React with 👍 / 👎.
Batch 13 — Wayland input injection strategy (Issue #21). Research/design spike. Wayland remains UNSUPPORTED for input injection. docs/wayland-input-strategy.md: - Backend hierarchy: X11+xdotool > portal+libei/EIS > legacy Notify* > ydotool/uinput > compositor-specific - Decision record: portal/libei preferred (consent-aware, standardized) - Implementation phases: detection (now) > portal prototype (behind opt-in) > production - Full API reference: CreateSession, SelectDevices, Start, ConnectToEIS, Notify* methods deskaoy doctor extensions: - _detect_wayland_portal(): side-effect-free check for XDG RemoteDesktop portal service files - Reports portal backend (GNOME/KDE/wlroots) if detected - Reports libei availability (SKIP if not installed) - All portal checks are WARN/SKIP, never FAIL RELEASE_READINESS.md: updated Wayland section with strategy reference and portal detection note. Tests: 6 tests covering portal not-detected (WARN), portal detected (WARN), libei SKIP/WARN, no-hard-failures invariant, Wayland input still UNSUPPORTED. Signed-off-by: Alajmah <55954113+Alajmah@users.noreply.github.com>
da98919 to
3d6ec97
Compare
Batch 13 — Wayland input strategy
Issue: #21
Research/design spike. Wayland remains UNSUPPORTED for input injection.
Deliverables
docs/wayland-input-strategy.md — Full backend decision record:
deskaoy doctor — Extended for Wayland portal detection:
RELEASE_READINESS.md — Updated Wayland section with strategy reference.
What was NOT done
Verification