Repository navigation
app: redact bn URLs in version checks and exit fetch - #4814
Merged
Merged
Conversation
Missed by #4813: the beacon node version checks log the configured addresses, and exit fetch logs the endpoints when the client fails.
KaloyanTanev
previously approved these changes
Oct 28, 2026
OisinKyne
changed the title
OisinKyne
changed the title
OisinKyne
added
the
merge when ready
Move fetching all exits and fetching one exit out of runFetchExit to bring its cognitive complexity under the limit. No behaviour change.
|
KaloyanTanev
approved these changes
Oct 28, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4814 +/- ##
==========================================
+ Coverage 67.63% 67.65% +0.01%
==========================================
Files 255 255
Lines 33659 33664 +5
==========================================
+ Hits 22766 22776 +10
+ Misses 10892 10887 -5
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed by #4813: the beacon node version checks log the configured addresses, and exit fetch logs the endpoints when the client fails.
category: bug
ticket: none