Repository navigation
Conversation
Design doc for making chain_split_halt halts legible, actionable and pre-emptive, following dvt-c3's 2/2 split during the cancelled Hoodi Gloas fork. category: docs ticket: none feature_flag: chain_split_halt
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4812 +/- ##
==========================================
+ Coverage 67.61% 67.68% +0.07%
==========================================
Files 254 254
Lines 33609 33685 +76
==========================================
+ Hits 22725 22800 +75
- Misses 10883 10884 +1
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Adds
docs/design/chain-split-halt.md, a design doc and plan for polishing thechain_split_haltfeature. It was prompted by its first real chain split: dvt-c3 split 2/2 during the cancelled Hoodi Gloas fork on 2026-10-26.Safety held. The cluster reached no decision while the split lasted, so no key share signed on the dead branch, and it recovered once the clients were upgraded. The operator experience did not hold up:
readyzstayed 1;insufficient_round_changes;no_consensusor asbug_fetch_error;The doc lays out the incident timeline from metrics and proposes the following changes for discussion:
core_consensus_compare_failed_total{duty,field}metric and replace the per-round WARN with one actionable ERROR;chain_split_halttracker reason.bug_fetch_errormisclassification;Comparing head votes is explicitly a non-goal. Head votes aren't slashable, and halting on them would turn ordinary propagation jitter into missed attestations.
The aim is to agree here on what we implement and why. Implementation PRs will follow separately.
category: docs
ticket: none
feature_flag: chain_split_halt