Repository navigation
Conversation
Replaces pbio.NewDelimitedReader with a reader using the same wire format and error semantics that grows its buffer as bytes arrive instead of allocating the declared length up front, so a peer declaring a large frame but sending little cannot pin a large buffer. Applies the same to dkg/sync readSizedProto. Per-protocol read limits and the 128MB maximum are unchanged. category: bug ticket: none
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4810 +/- ##
==========================================
+ Coverage 67.61% 67.63% +0.01%
==========================================
Files 254 255 +1
Lines 33609 33645 +36
==========================================
+ Hits 22725 22756 +31
- Misses 10883 10888 +5
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces pbio.NewDelimitedReader with a reader using the same wire format and error semantics that grows its buffer as bytes arrive instead of allocating the declared length up front, so a peer declaring a large frame but sending little cannot pin a large buffer. Applies the same to dkg/sync readSizedProto. Per-protocol read limits and the 128MB maximum are unchanged.
category: bug
ticket: none