Skip to content

*: cross-compile the docker image instead of emulating arm64 #4802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OisinKyne wants to merge 2 commits into
base: main
Choose a base branch
from
Open

*: cross-compile the docker image instead of emulating arm64 #4802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad29815
*: cross-compile the docker image instead of emulating arm64
OisinKyne Oct 21, 2026
7600f72
Dockerfile: echo target os and arch
KaloyanTanev Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 30 additions & 8 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,20 @@
# Container for building Go binary.
FROM golang:1.27.3-trixie AS builder
# Install dependencies
RUN apt-get update && apt-get install -y --no-install-recommends build-essential git
# Container for building Go binary. It always runs on the build platform and
# cross-compiles for the target platform, so multi-platform builds don't compile
# under QEMU emulation.
FROM --platform=$BUILDPLATFORM golang:1.27.3-trixie AS builder
ARG BUILDARCH
ARG TARGETOS
ARG TARGETARCH
# Install dependencies, plus a cgo cross compiler when the target arch differs
# from the build arch (herumi bls requires cgo).
RUN apt-get update && apt-get install -y --no-install-recommends build-essential git \
&& if [ "$TARGETARCH" != "$BUILDARCH" ]; then \
case "$TARGETARCH" in \
arm64) apt-get install -y --no-install-recommends gcc-aarch64-linux-gnu libc6-dev-arm64-cross ;; \
amd64) apt-get install -y --no-install-recommends gcc-x86-64-linux-gnu libc6-dev-amd64-cross ;; \
*) echo "unsupported TARGETARCH=$TARGETARCH" && exit 1 ;; \
esac; \
fi

# Prep and copy source
WORKDIR /app/charon
Expand All @@ -11,14 +24,20 @@
# Populate GO_BUILD_FLAG with a build arg to provide an optional go build flag.
ARG GO_BUILD_FLAG
ENV GO_BUILD_FLAG=${GO_BUILD_FLAG}
RUN echo "Building with GO_BUILD_FLAG='${GO_BUILD_FLAG}'"
RUN echo "Building for ${TARGETOS}/${TARGETARCH} on ${BUILDARCH} with GO_BUILD_FLAG='${GO_BUILD_FLAG}'"

# Build with Go module and Go build caches.
# Build with Go module and Go build caches (the build cache keys entries by
# GOARCH, so both target arches can share it).
RUN \
--mount=type=cache,target=/go/pkg \
--mount=type=cache,target=/root/.cache/go-build \
go build -o charon "${GO_BUILD_FLAG}" .
RUN echo "Built charon version=$(./charon version)"
if [ "$TARGETARCH" != "$BUILDARCH" ]; then \
case "$TARGETARCH" in \

Check failure on line 35 in Dockerfile

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Add a default case (*) to handle unexpected values. 


See more on https://sonarcloud.io/project/issues?id=ObolNetwork_charon&issues=AaGMElkgbIuBhEbH2nvu&open=AaGMElkgbIuBhEbH2nvu&pullRequest=4802
arm64) export CC=aarch64-linux-gnu-gcc ;; \
amd64) export CC=x86_64-linux-gnu-gcc ;; \
esac; \
fi \
&& CGO_ENABLED=1 GOOS="$TARGETOS" GOARCH="$TARGETARCH" go build -o charon "${GO_BUILD_FLAG}" .

@KaloyanTanev KaloyanTanev Oct 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabling CGO isn't as trivial of a change. I'll need some time to evaluate it.

@KaloyanTanev KaloyanTanev Oct 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK.


# Copy final binary into light stage.
FROM debian:trixie-slim
Expand All @@ -33,6 +52,9 @@
ENV GITHUB_SHA=${GITHUB_SHA}

COPY --from=builder /app/charon/charon /usr/local/bin/
# Sanity check the binary on the target platform (the builder can't run a
# cross-compiled binary).
RUN version="$(/usr/local/bin/charon version)" && echo "Built charon version=${version}"

# Don't run container as root
ENV USER=charon
Expand Down
19 changes: 14 additions & 5 deletions testutil/promrated/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,23 @@
FROM golang:1.27.3-alpine AS builder
# Build on the build platform and cross-compile for the target platform, so
# multi-platform builds don't compile under QEMU emulation. promrated has no cgo
# dependencies, so a pure Go build cross-compiles without a C toolchain.
FROM --platform=$BUILDPLATFORM golang:1.27.3-alpine AS builder

# Install dependencies
RUN apk add --no-cache build-base git
# Install dependencies (git for VCS build info)
RUN apk add --no-cache git

WORKDIR /app

COPY . .

# Build with Go module and Go build caches.
RUN go build -o promrated github.com/obolnetwork/charon/testutil/promrated/promrated
ARG TARGETOS
ARG TARGETARCH
RUN CGO_ENABLED=0 GOOS="$TARGETOS" GOARCH="$TARGETARCH" \
go build -o promrated github.com/obolnetwork/charon/testutil/promrated/promrated

FROM alpine:3.24

COPY --from=builder /app/promrated /app/promrated

# Don't run container as root
ENV USER=promrated
Expand Down
Loading