Skip to content

core/tracker: debug log sync selection proof inconsistency - #4801

Open
KaloyanTanev wants to merge 1 commit into
mainfrom
kalo/tracker-sync-selection-log
Open

KaloyanTanev wants to merge 1 commit into
mainfrom
kalo/tracker-sync-selection-log

Conversation

@KaloyanTanev

Copy link
Copy Markdown
Collaborator

Logs prepare_sync_contribution partial signature inconsistency at debug, like sync_contribution. A validator in several sync subcommittees signs a selection proof per subcommittee, which parsigdb keys by subcommittee, but the tracker groups by pubkey only and warned on every such validator (thousands per epoch in kurtosis).

category: misc
ticket: none

@KaloyanTanev KaloyanTanev self-assigned this Oct 21, 2026
@sonarqubecloud

Copy link
Copy Markdown

@KaloyanTanev
KaloyanTanev marked this pull request as ready for review October 21, 2026 14:47
@codecov

codecov Bot commented Oct 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.62%. Comparing base (bd4e892) to head (932b79a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4801   +/-   ##
=======================================
  Coverage   67.61%   67.62%           
=======================================
  Files         254      254           
  Lines       33609    33609           
=======================================
+ Hits        22725    22727    +2     
+ Misses      10883    10881    -2     
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@OisinKyne OisinKyne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4801: debug-log sync selection-proof inconsistency

Fine. A validator in several sync subcommittees signs one selection proof per subcommittee. parsigdb keys these by subcommittee, but the tracker groups by pubkey only, so the warning was a false alarm. Logging it at debug, as sync_contribution already does, is the right short-term fix.

  • The proper fix would be grouping by subcommittee in reportParSigs, which is the same pattern as the builder-preferences exemption in #4783. Debug-only also hides a real inconsistency for this duty. That's low stakes, since the selection proofs only decide who aggregates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants