Repository navigation
core/tracker: debug log sync selection proof inconsistency - #4801
Open
KaloyanTanev wants to merge 1 commit into
Open
KaloyanTanev wants to merge 1 commit into
KaloyanTanev wants to merge 1 commit into
Conversation
|
KaloyanTanev
marked this pull request as ready for review
October 21, 2026 14:47
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4801 +/- ##
=======================================
Coverage 67.61% 67.62%
=======================================
Files 254 254
Lines 33609 33609
=======================================
+ Hits 22725 22727 +2
+ Misses 10883 10881 -2
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
OisinKyne
approved these changes
Oct 21, 2026
OisinKyne
left a comment
Contributor
There was a problem hiding this comment.
#4801: debug-log sync selection-proof inconsistency
Fine. A validator in several sync subcommittees signs one selection proof per subcommittee. parsigdb keys these by subcommittee, but the tracker groups by pubkey only, so the warning was a false alarm. Logging it at debug, as sync_contribution already does, is the right short-term fix.
- The proper fix would be grouping by subcommittee in reportParSigs, which is the same pattern as the builder-preferences exemption in #4783. Debug-only also hides a real inconsistency for this duty. That's low stakes, since the selection proofs only decide who aggregates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Logs
prepare_sync_contributionpartial signature inconsistency at debug, likesync_contribution. A validator in several sync subcommittees signs a selection proof per subcommittee, which parsigdb keys by subcommittee, but the tracker groups by pubkey only and warned on every such validator (thousands per epoch in kurtosis).category: misc
ticket: none