Repository navigation
core: refetch payload attestation data at due time - #4797
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4797 +/- ##
==========================================
+ Coverage 67.59% 67.61% +0.02%
==========================================
Files 254 254
Lines 33589 33608 +19
==========================================
+ Hits 22705 22725 +20
+ Misses 10883 10882 -1
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
OisinKyne
approved these changes
Oct 21, 2026
OisinKyne
left a comment
Contributor
There was a problem hiding this comment.
Things to note
- Rolling-upgrade window. Round end times have to match across the cluster, and this changes the payload-attestation timer for every node. While old and new versions are mixed, those duties will likely round-change or fail. Ship it in the build everyone runs before the Hoodi fork epoch (Oct 26/27); Sepolia clusters will see it during their upgrade.
- One refetch means waiting on the leader's beacon node. If the leader's beacon node hasn't seen the blobs at 6s, the cluster waits until 9s, even when every other node saw them at 7s. Polling every 250 to 500ms between 6s and 9s (or using the execution_payload_available event later) would let most slots attest early. It's a small change inside the same function.
- Votes close to the 9s due time. In the fallback case, the message goes out at roughly 9.2 to 9.8s: consensus, then VC signing, partial-signature exchange and aggregation, all after 9s. That's inherent, since the spec doesn't allow reporting "missing" before 9s. It's still in time for the next proposer at 12s, and the Hoodi PTC metrics will show what it costs.
- Side effects of moving the slot offset from 6s to 9s.
- The duty's expiry deadline (core/deadline.go) moves 3s later, which is more lenient and fine.
- core_bcast_delay_seconds{duty="payload_attestation"} will now record negative delays for early (6s) broadcasts. That's cosmetic, but worth knowing before anyone builds PTC dashboards from that metric.
- Nit: when the first fetch errors, the debug log prints no_block from a zero-value struct. Harmless.
KaloyanTanev
marked this pull request as ready for review
October 21, 2026 14:00
KaloyanTanev
enabled auto-merge (squash)
October 21, 2026 14:00
KaloyanTanev
added a commit
that referenced
this pull request
Oct 21, 2026
* *: bump Go to 1.27.3 and distrust emSign/AAA roots in the image (#4796) Go 1.27.3 includes the crypto/x509 fix for CVE-2026-111943. Set toolchain go1.27.3 and bump the builder, promrated and CodeQL images. Distrust emSign ECC Root CA - G3 and AAA Certificate Services in the runtime image's system store until Debian's ca-certificates drops them everywhere. category: bug ticket: none * core: refetch payload attestation data at due time (#4797) * core: refetch payload attestation data at due time * core: ptc refetch cleanups and logging * *: fix v1 proposer duties dependent root before gloas (#4794) * app/eth2wrap: invalidate v1 proposer duties on epoch transition * core/scheduler: resolve proposer duties via v2 * testutil/validatormock: share preferences epoch helper * app: invalidate v1 proposer duties entering the epoch before gloas * core/scheduler: resolve proposer duties via v2 from gloas only * app/eth2wrap: pass v2 proposer duties metadata through synth wrapper * app/eth2wrap: don't cache v1 proposer duties from the epoch before gloas * cmd: default gas limits to 200M (#4795) * cmd: default target gas limit to 200M * app: add proposer-gas-limit flag defaulting to 200M --------- Co-authored-by: Oisín Kyne <4981644+OisinKyne@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Payload timeliness committee members should attest as soon as the payload and its blob data are seen, but only report either as missing once
PAYLOAD_ATTESTATION_DUE_BPS(9s) has elapsed, since blob data may still arrive (spec). Charon fetched once at the payload due time (6s), lockingblob_data_available=falsein early, and Prysm's 503 before 9s failed the duty.The fetcher now fetches again at the due time unless the first fetch reports both the payload and its blob data. PTC duties use the
eager_ahead_splittimer like gloas attesters, triggered at 6s with round 1 spanning to 10s, so a leader waiting for 9s needs no round change.category: bug
ticket: #4324