Repository navigation
cmd: default gas limits to 200M - #4795
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4795 +/- ##
==========================================
- Coverage 67.59% 67.58% -0.01%
==========================================
Files 254 254
Lines 33589 33569 -20
==========================================
- Hits 22705 22689 -16
+ Misses 10883 10879 -4
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
OisinKyne
approved these changes
Oct 21, 2026
OisinKyne
left a comment
Contributor
There was a problem hiding this comment.
2 might be worth it. 1 is likely ignorable no one runs the early gloas builds. 4 is a given. 3 idk so long as its fairly stable i'm happy, so i think for that, sticking as close as possible to el/cl policy will keep things in agreement
- Existing clusters don't move to 200M, despite the description.
- proposer-config.json is only written when it's missing (#4784 kept "never modify"), so existing nodes keep their 60M (or lock) value and their VCs keep signing it.
- The validator API now expects the flag's 200M, so every existing node logs a gas-limit mismatch warning on every preferences submission, plus the new startup warning.
- Either rewrite the gas limit in existing files (charon owns this value now, so that's consistent), or correct the description and tell operators to delete the file.
- Gas limit is now node-local, but it's part of the signed ProposerPreferences message.
- If operators end up with different values (one deletes their file, one sets the flag differently), the VC partials don't aggregate.
- Proposer preferences then fail, which means self-built blocks on every bid path. That was the #1 failure on Sepolia.
- The flag says "must be identical on all nodes", but unlike builder URLs nothing checks it: it isn't in the peerinfo builder-config hash or compared anywhere.
- Fold it into that hash, or at least warn when peers differ.
- It drops the cluster-agreed value. The lock's TargetGasLimit, which operators signed, no longer feeds the validator API's check or the VC config.
- Per-validator gas-limit overrides from signed registrations are also no longer carried into the VC config, but pre-gloas builder registrations still use them. So the pre- and post-fork values can differ.
- Consider defaulting to the lock value and using the flag only as an explicit override.
- Choosing 200M is a policy decision. Default-voting 200M across all of Obol's stake is a signal to the network, not just a client default. Worth confirming it matches what the EL and CL client teams ship for Glamsterdam before it becomes the default. I haven't verified their defaults.
KaloyanTanev
added a commit
that referenced
this pull request
Oct 21, 2026
* *: bump Go to 1.27.3 and distrust emSign/AAA roots in the image (#4796) Go 1.27.3 includes the crypto/x509 fix for CVE-2026-111943. Set toolchain go1.27.3 and bump the builder, promrated and CodeQL images. Distrust emSign ECC Root CA - G3 and AAA Certificate Services in the runtime image's system store until Debian's ca-certificates drops them everywhere. category: bug ticket: none * core: refetch payload attestation data at due time (#4797) * core: refetch payload attestation data at due time * core: ptc refetch cleanups and logging * *: fix v1 proposer duties dependent root before gloas (#4794) * app/eth2wrap: invalidate v1 proposer duties on epoch transition * core/scheduler: resolve proposer duties via v2 * testutil/validatormock: share preferences epoch helper * app: invalidate v1 proposer duties entering the epoch before gloas * core/scheduler: resolve proposer duties via v2 from gloas only * app/eth2wrap: pass v2 proposer duties metadata through synth wrapper * app/eth2wrap: don't cache v1 proposer duties from the epoch before gloas * cmd: default gas limits to 200M (#4795) * cmd: default target gas limit to 200M * app: add proposer-gas-limit flag defaulting to 200M --------- Co-authored-by: Oisín Kyne <4981644+OisinKyne@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Raise the
--target-gas-limitdefault forcreate clusterandcreate dkgfrom 60M to 200M, and add acharon run --proposer-gas-limitflag (default 200M) that sets the gas limit in the generated proposer-config and the expected proposer preferences target gas limit, so existing clusters move to 200M too.category: misc
ticket: none