Skip to content

*: fix v1 proposer duties dependent root before gloas - #4794

Merged
KaloyanTanev merged 7 commits into
mainfrom
kalo/proposer-duties-cache-epoch-invalidate
Oct 21, 2026
Merged

KaloyanTanev merged 7 commits into
mainfrom
kalo/proposer-duties-cache-epoch-invalidate

Conversation

@KaloyanTanev

@KaloyanTanev KaloyanTanev commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Fix the first gloas epoch's proposer preferences being rejected with InvalidDependentRoot. VCs prefetching the epoch before the fork get its v1 proposer duties cached with a provisional dependent_root, the head root at fetch time, which Prysm signs into the next epoch's preferences.

The duties cache no longer caches v1 proposer duties from the epoch before the gloas fork onwards, from which VCs resolve their duties via v2. The scheduler resolves proposer duties via v2 from the gloas fork only, since older beacon nodes do not serve it, and the synthetic proposer wrapper passes v2 metadata through. Mock VCs only submit preferences from gloas.

category: bug
ticket: #4324

@KaloyanTanev KaloyanTanev self-assigned this Oct 21, 2026
@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.37037% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.61%. Comparing base (957f2dd) to head (903e8ee).

Files with missing lines Patch % Lines
app/eth2wrap/synthproposer.go 71.42% 4 Missing ⚠️
app/vmock.go 0.00% 2 Missing ⚠️
app/app.go 0.00% 1 Missing ⚠️
core/scheduler/scheduler.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4794      +/-   ##
==========================================
+ Coverage   67.59%   67.61%   +0.01%     
==========================================
  Files         254      254              
  Lines       33589    33610      +21     
==========================================
+ Hits        22705    22724      +19     
- Misses      10883    10885       +2     
  Partials        1        1              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KaloyanTanev
KaloyanTanev marked this pull request as ready for review October 21, 2026 10:17
@KaloyanTanev KaloyanTanev changed the title app/eth2wrap: invalidate v1 proposer duties each epoch *: fix v1 proposer duties dependent root before gloas Oct 21, 2026
@KaloyanTanev
KaloyanTanev force-pushed the kalo/proposer-duties-cache-epoch-invalidate branch from 3194604 to 903e8ee Compare October 21, 2026 12:49
@sonarqubecloud

Copy link
Copy Markdown

@OisinKyne OisinKyne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions before merging:

  1. The scheduler now requires /eth/v2/validator/duties/proposer on every fork, mainnet included.
    • go-eth2-client's ProposerDutiesV2 has no fallback to v1. If any supported beacon node lacks the v2 endpoint, the scheduler can't resolve proposer duties, and every proposal is missed silently.
    • The minimum beacon node version check still allows Lighthouse v8.0.0, and I don't know which versions added v2 proposer duties.
    • Either fall back to v1 on 404/405, or use v2 only once gloas is active (or one epoch before). That's cheap, and safer for a release that also goes to mainnet.
  2. The VC can race the invalidation. It happens in the slot subscriber at the first slot of G-1. A VC that refreshes its duties at that same slot can be served the stale cached entry before charon drops it. Has this been checked against Prysm's refresh timing, or seen working on a devnet fork?
    • A more general option: never keep v1 duties cached for an epoch whose dependent-root slot hadn't passed when they were fetched. That would also stop this from coming back at the next fork.

@KaloyanTanev
KaloyanTanev merged commit 3dd3286 into main Oct 21, 2026
13 checks passed
@KaloyanTanev
KaloyanTanev deleted the kalo/proposer-duties-cache-epoch-invalidate branch October 21, 2026 14:07
KaloyanTanev added a commit that referenced this pull request Oct 21, 2026
* *: bump Go to 1.27.3 and distrust emSign/AAA roots in the image (#4796)

Go 1.27.3 includes the crypto/x509 fix for CVE-2026-111943. Set toolchain
go1.27.3 and bump the builder, promrated and CodeQL images. Distrust emSign
ECC Root CA - G3 and AAA Certificate Services in the runtime image's system
store until Debian's ca-certificates drops them everywhere.

category: bug
ticket: none

* core: refetch payload attestation data at due time (#4797)

* core: refetch payload attestation data at due time

* core: ptc refetch cleanups and logging

* *: fix v1 proposer duties dependent root before gloas (#4794)

* app/eth2wrap: invalidate v1 proposer duties on epoch transition

* core/scheduler: resolve proposer duties via v2

* testutil/validatormock: share preferences epoch helper

* app: invalidate v1 proposer duties entering the epoch before gloas

* core/scheduler: resolve proposer duties via v2 from gloas only

* app/eth2wrap: pass v2 proposer duties metadata through synth wrapper

* app/eth2wrap: don't cache v1 proposer duties from the epoch before gloas

* cmd: default gas limits to 200M (#4795)

* cmd: default target gas limit to 200M

* app: add proposer-gas-limit flag defaulting to 200M

---------

Co-authored-by: Oisín Kyne <4981644+OisinKyne@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants