Repository navigation
*: fix v1 proposer duties dependent root before gloas - #4794
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4794 +/- ##
==========================================
+ Coverage 67.59% 67.61% +0.01%
==========================================
Files 254 254
Lines 33589 33610 +21
==========================================
+ Hits 22705 22724 +19
- Misses 10883 10885 +2
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
KaloyanTanev
marked this pull request as ready for review
October 21, 2026 10:17
KaloyanTanev
force-pushed
the
kalo/proposer-duties-cache-epoch-invalidate
branch
from
October 21, 2026 12:49
3194604 to
903e8ee
Compare
|
OisinKyne
approved these changes
Oct 21, 2026
OisinKyne
left a comment
Contributor
There was a problem hiding this comment.
Two questions before merging:
- The scheduler now requires /eth/v2/validator/duties/proposer on every fork, mainnet included.
- go-eth2-client's ProposerDutiesV2 has no fallback to v1. If any supported beacon node lacks the v2 endpoint, the scheduler can't resolve proposer duties, and every proposal is missed silently.
- The minimum beacon node version check still allows Lighthouse v8.0.0, and I don't know which versions added v2 proposer duties.
- Either fall back to v1 on 404/405, or use v2 only once gloas is active (or one epoch before). That's cheap, and safer for a release that also goes to mainnet.
- The VC can race the invalidation. It happens in the slot subscriber at the first slot of G-1. A VC that refreshes its duties at that same slot can be served the stale cached entry before charon drops it. Has this been checked against Prysm's refresh timing, or seen working on a devnet fork?
- A more general option: never keep v1 duties cached for an epoch whose dependent-root slot hadn't passed when they were fetched. That would also stop this from coming back at the next fork.
KaloyanTanev
added a commit
that referenced
this pull request
Oct 21, 2026
* *: bump Go to 1.27.3 and distrust emSign/AAA roots in the image (#4796) Go 1.27.3 includes the crypto/x509 fix for CVE-2026-111943. Set toolchain go1.27.3 and bump the builder, promrated and CodeQL images. Distrust emSign ECC Root CA - G3 and AAA Certificate Services in the runtime image's system store until Debian's ca-certificates drops them everywhere. category: bug ticket: none * core: refetch payload attestation data at due time (#4797) * core: refetch payload attestation data at due time * core: ptc refetch cleanups and logging * *: fix v1 proposer duties dependent root before gloas (#4794) * app/eth2wrap: invalidate v1 proposer duties on epoch transition * core/scheduler: resolve proposer duties via v2 * testutil/validatormock: share preferences epoch helper * app: invalidate v1 proposer duties entering the epoch before gloas * core/scheduler: resolve proposer duties via v2 from gloas only * app/eth2wrap: pass v2 proposer duties metadata through synth wrapper * app/eth2wrap: don't cache v1 proposer duties from the epoch before gloas * cmd: default gas limits to 200M (#4795) * cmd: default target gas limit to 200M * app: add proposer-gas-limit flag defaulting to 200M --------- Co-authored-by: Oisín Kyne <4981644+OisinKyne@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fix the first gloas epoch's proposer preferences being rejected with
InvalidDependentRoot. VCs prefetching the epoch before the fork get its v1 proposer duties cached with a provisionaldependent_root, the head root at fetch time, which Prysm signs into the next epoch's preferences.The duties cache no longer caches v1 proposer duties from the epoch before the gloas fork onwards, from which VCs resolve their duties via v2. The scheduler resolves proposer duties via v2 from the gloas fork only, since older beacon nodes do not serve it, and the synthetic proposer wrapper passes v2 metadata through. Mock VCs only submit preferences from gloas.
category: bug
ticket: #4324