In scope=false assets fix #312
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes issue #310, where threat findings from out-of-scope elements were still rendered in generated reports.
The fix centralizes scope filtering inside ReportUtils and updates all report templates to use scope-safe helper methods, preventing accidental leakage of findings.
What was changed
Code:
1)pytm/report_util.py
Added helper methods that return only in-scope findings
Introduced scope-safe accessors for:
Templates:
1)docs/basic_template.md
2)docs/advanced_template.md
3)docs/reveal.md
All templates were updated to:
Why this fixes the bug:
With this change:
How this was verified
Generated reports using:
Verified that:
Notes: