feat: graded output for MAL- advisories from git sources#621
Open
sonukapoor wants to merge 4 commits into
Open
feat: graded output for MAL- advisories from git sources#621sonukapoor wants to merge 4 commits into
sonukapoor wants to merge 4 commits into
Conversation
…rom private registry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a MAL- advisory matches a package installed from a git/tarball source (GitHub, GitLab, Bitbucket), show a graded warning with context instead of the alarming 'Remove it from your dependencies immediately.' message.
The advisory is still surfaced — just with accurate framing so teams can triage rather than panic.
What changed
isGitSource()andhasCommitShaPinning()insrc/utils/advisory.tsmaliciousGitSource+maliciousGitSourcePinned; private registry →maliciousUnverifiable(unchanged); npm registry → confirmed malicious (unchanged)⚠ Git source (SHA-pinned)or⚠ Git source (floating ref)with resolved URLbadge-git-sourcebadge variantexamples/git-source-mal/fixture demonstrating the outputExample output (compact)
Reported by a Discord engineer whose first-party GitHub-hosted packages were flagged as malicious.
Closes #618