Skip to content

fix: add missing SEO meta tags to metadata.svelte and news/[slug] #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
10-trix wants to merge 5 commits into
base: master
Choose a base branch
from
+73 −26
Open

fix: add missing SEO meta tags to metadata.svelte and news/[slug] #2946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a992e59
fix: add missing SEO meta tags to metadata.svelte and news/[slug]
10-trix May 8, 2026
851ea75
fix: remove duplicate title/description from global meta data to avoi…
10-trix May 9, 2026
d3e1d28
fix: null-safety fallback for markdown and remove og:type from global…
10-trix May 9, 2026
d7f7263
fix: apply consistent null-safety fallback to all 3 description meta …
10-trix May 23, 2026
9734dc0
fix: malformed anchor tag and restore og:type to global metadata
10-trix Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions cornucopia.owasp.org/src/lib/components/metadata.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
<svelte:head>
<!-- Facebook Meta Tags -->
<meta property="og:url" content="https://cornucopia.owasp.org/">
<meta property="og:type" content="website">
<meta property="og:image" content="/images/opengraph.png">
<meta property="og:url" content="https://cornucopia.owasp.org/" />
<meta property="og:type" content="website" />
<meta property="og:image" content="/images/opengraph.png" />
Comment thread
sydseter marked this conversation as resolved.

Comment on lines 2 to 6

@sydseter sydseter Jun 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at this. You can't remove og:type from components/metadata.svelte as that is used on all pages. What you can do, is to create a custom metadata.svelte for the news pages.

<!-- Twitter Meta Tags -->
<meta name="twitter:card" content="summary_large_image">
<meta property="twitter:domain" content="cornucopia.owasp.org">
<meta property="twitter:url" content="https://cornucopia.owasp.org/">
<meta name="twitter:image" content="/images/opengraph.png">
<meta name="twitter:card" content="summary_large_image" />
<meta property="twitter:domain" content="cornucopia.owasp.org" />
<meta property="twitter:url" content="https://cornucopia.owasp.org/" />
<meta name="twitter:image" content="/images/opengraph.png" />
<!-- END of Tags -->
</svelte:head>
85 changes: 66 additions & 19 deletions cornucopia.owasp.org/src/routes/news/[slug]/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,35 +1,82 @@
<script>
import SvelteMarkdown from 'svelte-markdown'
import { newsRenderers } from '$lib/components/renderers/renderers';
import BlogpostMetadata from '$lib/components/blogpostMetadata.svelte';
import {readTranslation} from "$lib/stores/stores";
import SvelteMarkdown from "svelte-markdown";
import { newsRenderers } from "$lib/components/renderers/renderers";
import BlogpostMetadata from "$lib/components/blogpostMetadata.svelte";
import { readTranslation } from "$lib/stores/stores";
let t = readTranslation();
/** @type {{data: any}} */
let { data } = $props();
let blogpost = $derived(data.blogpost);
let markdownRenderers = /** @type {any} */ (newsRenderers);
</script>

<svelte:head>
<link rel="canonical" href="/news" />
<title>{blogpost.title} | OWASP Cornucopia</title>
<link
rel="canonical"
href="https://cornucopia.owasp.org/news/{blogpost.path}"
/>
<meta
name="description"
content={(blogpost.markdown || "")
.replace(/[#*_>`]/g, "")
.replace(/\n+/g, " ")
.trim()
.slice(0, 160)}
Comment thread
sydseter marked this conversation as resolved.
/>

<!-- Facebook Meta Tags -->
<meta
property="og:url"
content="https://cornucopia.owasp.org/news/{blogpost.path}"
/>
<meta property="og:type" content="article" />
<meta property="og:title" content="{blogpost.title} | OWASP Cornucopia" />
<meta
property="og:description"
content={(blogpost.markdown || "")
.replace(/[#*_>`]/g, "")
.replace(/\n+/g, " ")
.trim()
.slice(0, 160)}
/>
<meta property="og:image" content="/images/opengraph.png" />

<!-- Twitter Meta Tags -->
<meta name="twitter:card" content="summary_large_image" />
<meta name="twitter:title" content="{blogpost.title} | OWASP Cornucopia" />
<meta
name="twitter:description"
content={(blogpost.markdown || "")
.replace(/[#*_>`]/g, "")
.replace(/\n+/g, " ")
.trim()
.slice(0, 160)}
/>
<meta name="twitter:image" content="/images/opengraph.png" />
Comment thread
sydseter marked this conversation as resolved.
</svelte:head>
<div>
<BlogpostMetadata {blogpost}></BlogpostMetadata>
<SvelteMarkdown renderers={markdownRenderers} source={blogpost.markdown}></SvelteMarkdown>
<p>
<a title="OWASP Cornucopia's repository" rel="noopener" href="https://github.com/OWASP/cornucopia/tree/master/cornucopia.owasp.org/data/news/{blogpost.path}/index.md">{$t('news.slug.p1')}</a>
</p>
<BlogpostMetadata {blogpost}></BlogpostMetadata>
<SvelteMarkdown renderers={markdownRenderers} source={blogpost.markdown}
></SvelteMarkdown>
<p>
<a
title="OWASP Cornucopia's repository"
rel="noopener"
href="https://github.com/OWASP/cornucopia/tree/master/cornucopia.owasp.org/data/news/{blogpost.path}/index.md"
>{$t("news.slug.p1")}</a
>
Comment on lines +63 to +68
</p>
</div>

<style>
p
{
p {
text-align: center;
}

@media (max-width: 767px)
{
div
{
margin: 0rem 1rem;
}
@media (max-width: 767px) {
div {
margin: 0rem 1rem;
}
}
</style>
</style>
Loading