Skip to content

[Security Fix] SAST: NoSQL/server-side JS injection via $where with unsanitized threshold query ... #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
okaypatrick wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Security Fix] SAST: NoSQL/server-side JS injection via $where with unsanitized threshold query ... #413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions app/data/allocations-dao.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,23 +60,19 @@ const AllocationsDAO = function(db){
const searchCriteria = () => {

if (threshold) {
/*
// Fix for A1 - 2 NoSQL Injection - escape the threshold parameter properly
// Fix this NoSQL Injection which doesn't sanitze the input parameter 'threshold' and allows attackers
// to inject arbitrary javascript code into the NoSQL query:
// 1. 0';while(true){}'
// 2. 1'; return 1 == '1
// Also implement fix in allocations.html for UX.
// Fix for A1 - 2 NoSQL Injection - validate and coerce the threshold to a
// safe integer before using it in the query. Avoid using $where with
// unsanitized user input, which would allow server-side JS injection
// (e.g. "0';while(true){}'" or "1'; return 1 == '1").
const parsedThreshold = parseInt(threshold, 10);

if (parsedThreshold >= 0 && parsedThreshold <= 99) {
return {$where: `this.userId == ${parsedUserId} && this.stocks > ${parsedThreshold}`};

if (Number.isInteger(parsedThreshold) && parsedThreshold >= 0 && parsedThreshold <= 99) {
return {
userId: parsedUserId,
stocks: { $gt: parsedThreshold }
};
}
throw `The user supplied threshold: ${parsedThreshold} was not valid.`;
*/
return {
$where: `this.userId == ${parsedUserId} && this.stocks > '${threshold}'`
};
throw `The user supplied threshold: ${threshold} was not valid.`;
}
return {
userId: parsedUserId
Expand Down