Skip to content

[Security Fix] SAST: User-controlled url query parameter is fetched server-side and response bod... #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
okaypatrick wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Security Fix] SAST: User-controlled url query parameter is fetched server-side and response bod... #412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion app/routes/research.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,27 @@ function ResearchHandler(db) {

const researchDAO = new ResearchDAO(db);

// Allow-list of permitted upstream research providers. Only requests whose
// base URL exactly matches one of these origins are allowed, to prevent
// SSRF (e.g. fetching cloud metadata endpoints like 169.254.169.254).
const ALLOWED_RESEARCH_URLS = [
"https://www.google.com/finance?q=",
"https://finance.yahoo.com/quote/"
];

this.displayResearch = (req, res) => {

if (req.query.symbol) {
const url = req.query.url + req.query.symbol;
const baseUrl = req.query.url;
if (!ALLOWED_RESEARCH_URLS.includes(baseUrl)) {
res.writeHead(400, {
"Content-Type": "text/html"
});
res.write("<h1>Invalid research URL.</h1>");
return res.end();
}
const symbol = encodeURIComponent(req.query.symbol);
const url = baseUrl + symbol;
return needle.get(url, (error, newResponse, body) => {
if (!error && newResponse.statusCode === 200) {
res.writeHead(200, {
Expand Down