Skip to content

[Security Fix] SAST: Authenticated RCE via eval() applied to request body fields preTax/afterTax/r... #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
okaypatrick wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Security Fix] SAST: Authenticated RCE via eval() applied to request body fields preTax/afterTax/r... #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions app/routes/contributions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,10 @@ function ContributionsHandler(db) {

this.handleContributionsUpdate = (req, res, next) => {

/*jslint evil: true */
// Insecure use of eval() to parse inputs
const preTax = eval(req.body.preTax);
const afterTax = eval(req.body.afterTax);
const roth = eval(req.body.roth);
// Fix for A1 - SSJS Injection: parse inputs as integers instead of eval()
const preTax = parseInt(req.body.preTax, 10);
const afterTax = parseInt(req.body.afterTax, 10);
const roth = parseInt(req.body.roth, 10);

/*
//Fix for A1 -1 SSJS Injection attacks - uses alternate method to eval
Expand Down