Skip to content

Fix error SQL injection level 2 #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r1kka6 wants to merge 1 commit into
base: dc34-ctf
Choose a base branch
from
Open

Fix error SQL injection level 2 #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions ...org/sasanlabs/service/vulnerability/sqlInjection/ErrorBasedSQLInjectionVulnerability.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,16 @@ public ResponseEntity<String> doesCarInformationExistsLevel1(
htmlTemplate = "LEVEL_1/SQLInjection_Level1")
public ResponseEntity<String> doesCarInformationExistsLevel2(
@RequestParam Map<String, String> queryParams) {
String id = queryParams.get(Constants.ID);
final String id = queryParams.get(Constants.ID);
BodyBuilder bodyBuilder = ResponseEntity.status(HttpStatus.OK);
bodyBuilder.body(ErrorBasedSQLInjectionVulnerability.CAR_IS_NOT_PRESENT_RESPONSE);
try {
ResponseEntity<String> response =
applicationJdbcTemplate.query(
"select * from cars where id='" + id + "'",
(conn) -> conn.prepareStatement("select * from cars where id=?"),
(prepareStatement) -> {
prepareStatement.setString(1, id);
},
(rs) -> {
if (rs.next()) {
CarInformation carInformation = new CarInformation();
Expand All @@ -124,7 +128,8 @@ public ResponseEntity<String> doesCarInformationExistsLevel2(
} catch (JsonProcessingException e) {
LOGGER.error("Following error occurred", e);
return bodyBuilder.body(
GENERIC_EXCEPTION_RESPONSE_FUNCTION.apply(e));
ErrorBasedSQLInjectionVulnerability
.CAR_IS_NOT_PRESENT_RESPONSE);
}
} else {
return bodyBuilder.body(
Expand All @@ -135,7 +140,8 @@ public ResponseEntity<String> doesCarInformationExistsLevel2(
return response;
} catch (Exception ex) {
LOGGER.error("Following error occurred", ex);
return bodyBuilder.body(GENERIC_EXCEPTION_RESPONSE_FUNCTION.apply(ex));
return bodyBuilder.body(
ErrorBasedSQLInjectionVulnerability.CAR_IS_NOT_PRESENT_RESPONSE);
}
}

Expand Down
28 changes: 23 additions & 5 deletions ...sasanlabs/service/vulnerability/sqlInjection/ErrorBasedSQLInjectionVulnerabilityTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.eq;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.verify;

import java.io.IOException;
Expand Down Expand Up @@ -59,16 +60,33 @@ void doesCarInformationExistsLevel1_ExpectParamEscaped() throws IOException {
}

@Test
void doesCarInformationExistsLevel2_ExpectParamEscaped() throws IOException {
void doesCarInformationExistsLevel2_ExpectValidResponse() {
// Arrange
Map<String, String> queryParams = new HashMap<>();
queryParams.put(Constants.ID, "1");

ResponseEntity<String> mockResponseEntity =
ResponseEntity.status(HttpStatus.OK).body("Sample response");
doReturn(mockResponseEntity)
.when(template)
.query(
Mockito.any(PreparedStatementCreator.class),
Mockito.any(PreparedStatementSetter.class),
Mockito.any(ResultSetExtractor.class));

// Act
final Map<String, String> queryParams = Collections.singletonMap("id", "1");
errorBasedSQLInjectionVulnerability.doesCarInformationExistsLevel2(queryParams);
ResponseEntity<String> response =
errorBasedSQLInjectionVulnerability.doesCarInformationExistsLevel2(queryParams);

// Assert
assertEquals(HttpStatus.OK, response.getStatusCode());
assertEquals("Sample response", response.getBody());
verify(template)
.query(
eq("select * from cars where id='1'"),
(ResultSetExtractor<? extends Object>) any());
Mockito.any(PreparedStatementCreator.class),
Mockito.any(PreparedStatementSetter.class),
Mockito.any(ResultSetExtractor.class));
verify(template, never()).query(anyString(), (ResultSetExtractor<? extends Object>) any());
}

@Test
Expand Down