Skip to content

fix: isolate cache poisoning level 1 banners - #231

Open
tobymoreno wants to merge 1 commit into
OWASP-CTF:dc34-ctffrom
tobymoreno:fix/vulnerableapp-cache-poisoning-level1
Open

tobymoreno wants to merge 1 commit into
OWASP-CTF:dc34-ctffrom
tobymoreno:fix/vulnerableapp-cache-poisoning-level1

Conversation

@tobymoreno

Copy link
Copy Markdown

Summary

  • include the banner value in the Level 1 shared-cache key
  • HTML-escape reflected banner content before rendering
  • prevent attacker banners and stored XSS payloads from replaying to plain requests
  • update regression coverage for cache misses, key separation, and escaping

Validation

  • ./gradlew test --tests org.sasanlabs.service.vulnerability.cachePoisoning.CachePoisoningVulnerabilityTest
  • ./gradlew spotlessCheck test
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant