Skip to content

Ignore IDOR level 4 encoded role cookie #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r1kka6 wants to merge 1 commit into
base: dc34-ctf
Choose a base branch
from
Open

Ignore IDOR level 4 encoded role cookie #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/sasanlabs/service/vulnerability/idor/IDORVulnerability.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ public ResponseEntity<GenericVulnerabilityResponseBean<Object>> level4(
if (actualToken != null) {
User decodedUser = idorLoginService.decodeToken(actualToken);
int tokenUserId = decodedUser.getUserId();
String role = cookieRole != null ? decodeBase64(cookieRole) : decodedUser.getRole();
String role = decodedUser.getRole();

if (id == null) {
id = tokenUserId;
Expand Down
22 changes: 6 additions & 16 deletions src/test/java/org/sasanlabs/service/vulnerability/idor/IDORVulnerabilityTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ void level3_ShouldAllowRoleEscalationWhenRoleCookieIsAdmin() {
}

@Test
void level4_ShouldAllowOpaqueIdAccess() {
void level4_ShouldRejectEncodedRoleEscalation() {
String encodedRole =
java.util.Base64.getUrlEncoder()
.withoutPadding()
Expand All @@ -112,19 +112,14 @@ void level4_ShouldAllowOpaqueIdAccess() {
User decoded = new User();
decoded.setUserId(1);
decoded.setRole("USER");
User bob = new User(2, "Bob", 60000, "USER");

when(idorLoginService.decodeToken(escalatedToken)).thenReturn(decoded);
when(jdbcTemplate.query(
anyString(),
any(Object[].class),
any(org.springframework.jdbc.core.RowMapper.class)))
.thenReturn(Arrays.asList(bob));

ResponseEntity<GenericVulnerabilityResponseBean<Object>> response =
idor.level4(escalatedToken, encodedRole, 2);

assertTrue(response.getBody().getIsValid());
assertFalse(response.getBody().getIsValid());
assertEquals("Access Denied - Insufficient privileges", response.getBody().getContent());
}

@Test
Expand Down Expand Up @@ -173,7 +168,7 @@ void level3_ShouldRejectInvalidToken() {
}

@Test
void level4_ShouldAllowAccessToAnyOpaqueIdRegardlessOfRole() {
void level4_ShouldRejectCrossUserAccessWithEncodedAdminRole() {
String userToken =
java.util.Base64.getEncoder()
.encodeToString("{\"userId\":1,\"role\":\"USER\"}".getBytes());
Expand All @@ -185,19 +180,14 @@ void level4_ShouldAllowAccessToAnyOpaqueIdRegardlessOfRole() {
User decoded = new User();
decoded.setUserId(1);
decoded.setRole("USER");
User bob = new User(2, "Bob", 60000, "USER");

when(idorLoginService.decodeToken(userToken)).thenReturn(decoded);
when(jdbcTemplate.query(
anyString(),
any(Object[].class),
any(org.springframework.jdbc.core.RowMapper.class)))
.thenReturn(Arrays.asList(bob));

ResponseEntity<GenericVulnerabilityResponseBean<Object>> response =
idor.level4(userToken, encodedRole, 2);

assertTrue(response.getBody().getIsValid());
assertFalse(response.getBody().getIsValid());
assertEquals("Access Denied - Insufficient privileges", response.getBody().getContent());
}

@Test
Expand Down