Skip to content

Fix clickjacking level 1 framing protection #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r1kka6 wants to merge 1 commit into
base: dc34-ctf
Choose a base branch
from
Open

Fix clickjacking level 1 framing protection #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...main/java/org/sasanlabs/service/vulnerability/clickjacking/ClickjackingVulnerability.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,11 @@ public class ClickjackingVulnerability {
value = LevelConstants.LEVEL_1,
htmlTemplate = "LEVEL_1/ClickjackingVulnerability")
public ResponseEntity<GenericVulnerabilityResponseBean<String>> noFramingProtection() {
return ResponseEntity.ok(new GenericVulnerabilityResponseBean<>(VULNERABLE_RESPONSE, true));
HttpHeaders headers = new HttpHeaders();
headers.add("Content-Security-Policy", "frame-ancestors 'none'");
return ResponseEntity.ok()
.headers(headers)
.body(new GenericVulnerabilityResponseBean<>(PROTECTED_RESPONSE, true));
}

/**
Expand Down
13 changes: 5 additions & 8 deletions .../java/org/sasanlabs/service/vulnerability/clickjacking/ClickjackingVulnerabilityTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,15 @@ void setUp() {
}

@Test
@DisplayName("Level 1 - No X-Frame-Options header present, page fully vulnerable")
void test_Level1_NoFramingProtection_HeaderAbsent() {
@DisplayName("Level 1 - CSP frame-ancestors none prevents framing")
void test_Level1_CSP_FrameAncestors_None() {
ResponseEntity<GenericVulnerabilityResponseBean<String>> response =
clickjackingVulnerability.noFramingProtection();

assertThat(response.getStatusCode()).isEqualTo(HttpStatus.OK);
assertThat(response.getHeaders().get(X_FRAME_OPTIONS)).isNull();
assertThat(response.getHeaders().get(CONTENT_SECURITY_POLICY)).isNull();
assertThat(response.getHeaders().get(CONTENT_SECURITY_POLICY))
.contains("frame-ancestors 'none'");
}

@Test
Expand Down Expand Up @@ -98,10 +99,8 @@ void test_Level7_OverlayAttack_SameOrigin() {
}

@Test
@DisplayName("Vulnerable levels (1, 2, 3, 6, 7) do not set DENY or frame-ancestors none")
@DisplayName("Vulnerable levels (2, 3, 6, 7) do not set DENY or frame-ancestors none")
void test_VulnerableLevels_DoNotHaveSecureHeaders() {
ResponseEntity<GenericVulnerabilityResponseBean<String>> level1 =
clickjackingVulnerability.noFramingProtection();
ResponseEntity<GenericVulnerabilityResponseBean<String>> level2 =
clickjackingVulnerability.xFrameOptionsAllowAll();
ResponseEntity<GenericVulnerabilityResponseBean<String>> level3 =
Expand All @@ -111,13 +110,11 @@ void test_VulnerableLevels_DoNotHaveSecureHeaders() {
ResponseEntity<GenericVulnerabilityResponseBean<String>> level7 =
clickjackingVulnerability.overlayAttackSameOrigin();

assertThat(level1.getHeaders().get(X_FRAME_OPTIONS)).isNull();
assertThat(level2.getHeaders().get(X_FRAME_OPTIONS)).doesNotContain("DENY");
assertThat(level3.getHeaders().get(X_FRAME_OPTIONS)).doesNotContain("DENY");
assertThat(level6.getHeaders().get(X_FRAME_OPTIONS)).isNull();
assertThat(level7.getHeaders().get(X_FRAME_OPTIONS)).doesNotContain("DENY");

assertThat(level1.getHeaders().get(CONTENT_SECURITY_POLICY)).isNull();
assertThat(level2.getHeaders().get(CONTENT_SECURITY_POLICY)).isNull();
assertThat(level3.getHeaders().get(CONTENT_SECURITY_POLICY)).isNull();
assertThat(level6.getHeaders().get(CONTENT_SECURITY_POLICY)).isNull();
Expand Down