Skip to content

Fix BOLA: GET /books/v1/{book_title} leaks any user's secret_content #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
beanbeah wants to merge 1 commit into from
Closed

Fix BOLA: GET /books/v1/{book_title} leaks any user's secret_content #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 13 additions & 23 deletions api_views/books.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,26 +47,16 @@ def get_by_title(book_title):
if "error" in resp:
return Response(error_message_helper(resp), 401, mimetype="application/json")
else:
if vuln: # Broken Object Level Authorization
book = Book.query.filter_by(book_title=str(book_title)).first()
if book:
responseObject = {
'book_title': book.book_title,
'secret': book.secret_content,
'owner': book.user.username
}
return Response(json.dumps(responseObject), 200, mimetype="application/json")
else:
return Response(error_message_helper("Book not found!"), 404, mimetype="application/json")
else:
user = User.query.filter_by(username=resp['sub']).first()
book = Book.query.filter_by(user=user, book_title=str(book_title)).first()
if book:
responseObject = {
'book_title': book.book_title,
'secret': book.secret_content,
'owner': book.user.username
}
return Response(json.dumps(responseObject), 200, mimetype="application/json")
else:
return Response(error_message_helper("Book not found!"), 404, mimetype="application/json")
# Object-level authorization is enforced unconditionally here: a book's secret
# content must only ever be returned to the authenticated caller that owns it,
# regardless of the legacy `vuln` toggle used elsewhere in this app.
requesting_user = User.query.filter_by(username=resp['sub']).first()
candidate_book = Book.query.filter_by(book_title=str(book_title)).first()
if candidate_book is None or requesting_user is None or candidate_book.user_id != requesting_user.id:
return Response(error_message_helper("Book not found!"), 404, mimetype="application/json")
responseObject = {
'book_title': candidate_book.book_title,
'secret': candidate_book.secret_content,
'owner': candidate_book.user.username
}
return Response(json.dumps(responseObject), 200, mimetype="application/json")
Loading